MarcusBarnes / mik

The Move to Islandora Kit is an extensible PHP command-line tool for converting source content and metadata into packages suitable for importing into Islandora (or other digital repository and preservations systems).

GNU General Public License v3.0

34 stars 11 forks source link

Remove undefined variable #402

Closed whikloj closed 7 years ago

whikloj commented 7 years ago

Github issue: https://github.com/MarcusBarnes/mik/issues/401

What does this Pull Request do?

Remove undefined variables

mjordan commented 7 years ago

Copy pasta FTW! Thanks for catching these @whikloj.

We've recently adopted a new workflow where we indicate in the PR if the change is testable or requires a smoketest. Details are laid out in our CONTRIBUTING.md.

Want you name added to the main README under "Contributors"? It's a pretty illustrious group!

mjordan commented 7 years ago

Tested with no side effects. Thanks again @whikloj.

whikloj commented 7 years ago

Sorry about that @mjordan, I perused the PR template but I'll have to go in and really read the CONTRIBUTING.md. Thanks.

mjordan commented 7 years ago

No problem. We would appreciate any feedback on the CONTRIBUTING.md you might have.