Closed mjordan closed 7 years ago
Github issue: #403
Adds a fetcher capable of reading Excel (.xlsx) files. This fetcher is a drop-in replacement for the Csv fetcher in Csv toolchains.
This change is testable. To test:
composer update
phpunit --exclude-group inputvalidators --bootstrap vendor/autoload.php tests
We'll need to document the new Excel fetcher. Consistent with #372 and #373, I'm thinking something like https://github.com/MarcusBarnes/mik/wiki/Cookbook:-Templated-Metadata-Parser plus a mention in all the Csv toolchain wiki pages as an allowed option for [FETCHER] class. Draft is at https://github.com/MarcusBarnes/mik/wiki/Cookbook:-Using-the-Excel-fetcher (toolchain docs not updated yet).
[FETCHER] class
I've tested this new fetcher on Linux and Windows with CsvToMods and Templated metadata parsers, and appears to work as intended.
@MarcusBarnes
@whikloj this is an example of the 'testable' workflow I mentioned in #402.
Looks good. Running PHPUnit locally, I got OK (49 tests, 69 assertions) as expected. Thank you @mjordan.
OK (49 tests, 69 assertions)
Thanks for testing, having this in master will make work on #408 a lot easier.
Github issue: #403
What does this Pull Request do?
Adds a fetcher capable of reading Excel (.xlsx) files. This fetcher is a drop-in replacement for the Csv fetcher in Csv toolchains.
What's new?
How should this be tested?
This change is testable. To test:
composer update
or equivalent on your system.phpunit --exclude-group inputvalidators --bootstrap vendor/autoload.php tests
. You should get 49 tests, 69 assertions.composer update
.Additional Notes
We'll need to document the new Excel fetcher. Consistent with #372 and #373, I'm thinking something like https://github.com/MarcusBarnes/mik/wiki/Cookbook:-Templated-Metadata-Parser plus a mention in all the Csv toolchain wiki pages as an allowed option for
[FETCHER] class
. Draft is at https://github.com/MarcusBarnes/mik/wiki/Cookbook:-Using-the-Excel-fetcher (toolchain docs not updated yet).I've tested this new fetcher on Linux and Windows with CsvToMods and Templated metadata parsers, and appears to work as intended.
Interested parties
@MarcusBarnes
@whikloj this is an example of the 'testable' workflow I mentioned in #402.