search

MarcusBarnes / mik

The Move to Islandora Kit is an extensible PHP command-line tool for converting source content and metadata into packages suitable for importing into Islandora (or other digital repository and preservations systems).
GNU General Public License v3.0
34 stars 11 forks source link

Config: input_directories is optional for Cdm toolchains #410

Closed MarcusBarnes closed 7 years ago

MarcusBarnes commented 7 years ago

The configuration checking functionality currently assumes that input_directories in the FILE_GETTER section is required not optional. The wiki documentation for CdmSingleFile correctly points out that it is optional. When not included, you'll get a PHP offset error like:

“PHP Notice: Uninitialized string offset: 0 in /Users/barnes26/dev/mik/src/config/Config.php on line 273.”

Adjusting the logic around line 273 to confirm that input_directories configuration seeting exists before proceeding with the other checks should resolve the PHP notice.

mjordan commented 7 years ago

@MarcusBarnes I see you assigned yourself, but would you like me to take a crack at this, with you testing?

MarcusBarnes commented 7 years ago

That's fine if you have a chance to get to this now. Thanks.

mjordan commented 7 years ago

OK, will do.

MarcusBarnes commented 7 years ago

Addressed in pull-request https://github.com/MarcusBarnes/mik/pull/413 (merged with commit https://github.com/MarcusBarnes/mik/commit/a09226465febe91290250050447c55329b3f67a7).