MarcusBarnes / mik

The Move to Islandora Kit is an extensible PHP command-line tool for converting source content and metadata into packages suitable for importing into Islandora (or other digital repository and preservations systems).
GNU General Public License v3.0
34 stars 11 forks source link

Work on #410 - allow input directories to be optional in Cdm toolchains #413

Closed mjordan closed 7 years ago

mjordan commented 7 years ago

Github issue: #410

What does this Pull Request do?

Fixes --checkconfig so it considers input directories optional in CONTENTdm toolchains.

What's new?

--checkconfig no longer shows a notice when input directories are not configured: “PHP Notice: Uninitialized string offset: 0 in /Users/barnes26/dev/mik/src/config/Config.php on line 273.”

How should this be tested?

We need to smoke test test two situations, one where there are no input directories configured and one where there are.

mkdir /tmp/issue410_1
mkdir /tmp/issue410_2
mkdir /tmp/issue410_3

./mik -c issue-410.ini --cc all

You should see the following output:

Commencing MIK.
Mapping snippets are OK
Paths are OK
CONTENTdm aliases are OK
Input directory paths are OK.
URLs are OK

You should see the following output:

Commencing MIK.
Mapping snippets are OK
Paths are OK
CONTENTdm aliases are OK
No input directory paths are defined.
URLs are OK

Interested parties

@MarcusBarnes

MarcusBarnes commented 7 years ago

Smoke tested the two situations and got the expected results. Thank you @mjordan.