search

MarcusBarnes / mik

The Move to Islandora Kit is an extensible PHP command-line tool for converting source content and metadata into packages suitable for importing into Islandora (or other digital repository and preservations systems).
GNU General Public License v3.0
34 stars 11 forks source link

Change the abstract method in Filegettermanipulators to "manipulate()" to be consistent with other manipulators #414

Open mjordan opened 7 years ago

mjordan commented 7 years ago

Fetcher manipulators and metadata manipulators implement an abstract method, ->manipulate(), whereas filegetter manipulators implement a different abstract method, ->getMasterFilePaths(). This anomalous method is implemented in only one subclass, https://github.com/MarcusBarnes/mik/blob/master/src/filegetters/CdmSingleFile.php#L154.

In the interests of a consistent interface to manipulators, we should change the abstract method defined in https://github.com/MarcusBarnes/mik/blob/master/src/filegettermanipulators/Filegettermanipulator.php#L33 to ->manipulate(), and update https://github.com/MarcusBarnes/mik/blob/master/src/filegetters/CdmSingleFile.php#L154 to use the renamed method.

This issue is related to #400 and #406.