The Move to Islandora Kit is an extensible PHP command-line tool for converting source content and metadata into packages suitable for importing into Islandora (or other digital repository and preservations systems).
Github issue: None specifically, but covers #406 and does some of #277
What does this Pull Request do?
Corrects some variable names, removes some unused variables, updates some PHPDocs (where I could tell the purpose of the function), moves some functions up a level to use inheritance.
What's new?
Instead of listing it here, I'll stick comments right into the code where I think there might be some clarification necessary.
How should this be tested?
This should not impact code use at all. I would suggest run tests before and after and ensure the results are consistent.
To help reviewers test your work:
Indicate whether your work requires a smoke test or is covered by PHPUnit tests (see CONTRIBUTING.md for more information).
No new work, so existing tests should be sufficient.
If your work is covered by PHPUnit tests, indicate how many successful tests and assertions the reviewer should see when they run your tests.
If your work requires a smoke test, provide sample configuration files and data for reviewers.
Be as detailed as possible.
Good testing instructions and sample configuration files/data help get your PR completed faster.
Additional Notes
Any additional information that you think would be helpful when reviewing this PR.
Example:
Does this change require documentation to be updated? no
Does this change add any new dependencies? no
Could this change impact execution of existing code? no
whikloj
commented
7 years ago
Github issue: None specifically, but covers #406 and does some of #277
What does this Pull Request do?
Corrects some variable names, removes some unused variables, updates some PHPDocs (where I could tell the purpose of the function), moves some functions up a level to use inheritance.
What's new?
Instead of listing it here, I'll stick comments right into the code where I think there might be some clarification necessary.
How should this be tested?
This should not impact code use at all. I would suggest run tests before and after and ensure the results are consistent.
To help reviewers test your work:
No new work, so existing tests should be sufficient.
Additional Notes
Any additional information that you think would be helpful when reviewing this PR.
Example:
Interested parties