MarcusBarnes / mik

The Move to Islandora Kit is an extensible PHP command-line tool for converting source content and metadata into packages suitable for importing into Islandora (or other digital repository and preservations systems).
GNU General Public License v3.0
34 stars 11 forks source link

Several bugs in the sample content generator and CsvBooks writer; new integrations test script #426

Closed mjordan closed 7 years ago

mjordan commented 7 years ago

In preparation for merging #424, I discovered a couple of bugs with the sample content generator script:

And a bug in the CsvBooks writer:

I discovered these glitches while writing a script that (optionally) clones and installs MIK and IIPQA, uses MIK to generate sample input for single file, compound, book, and newspaper content models, runs MIK on this sample input, and then runs IIPQA on MIK's output. This script is related to discussion in #385 about running test content through MIK separate from unit tests.

I'll open a PR to fix these issues and add the script to extras/scripts.

MarcusBarnes commented 7 years ago

Initially addressed in pull-request https://github.com/MarcusBarnes/mik/pull/427 (merged with commit https://github.com/MarcusBarnes/mik/commit/709037bd5a581685eb96d5df629d6c707868501a).