Regex in filegetters/CsvBooks.php fails on Windows

MarcusBarnes / mik

The Move to Islandora Kit is an extensible PHP command-line tool for converting source content and metadata into packages suitable for importing into Islandora (or other digital repository and preservations systems).

GNU General Public License v3.0

34 stars 11 forks source link

Regex in filegetters/CsvBooks.php fails on Windows #428

Closed mjordan closed 7 years ago

mjordan commented 7 years ago

The regex at https://github.com/MarcusBarnes/mik/blob/master/src/filegetters/CsvBooks.php#L158 fails on Windows, where DIRECTORY_SEPARATOR is \, which escapes the succeeding character.

Also, the function determineObjItems() can be eliminated without loss of functionality.

Once PR #424 has been merged, I'll open a PR to add this cleaned up class.

mjordan commented 7 years ago

As far as I can tell, work on this issue should be merged into master before work on #421.

MarcusBarnes commented 7 years ago

Address in pull-request https://github.com/MarcusBarnes/mik/pull/429 (merged with commit https://github.com/MarcusBarnes/mik/commit/830b54df8ca06bcaa985edd07c1968afb38b64bd).