MarcusBarnes / mik

The Move to Islandora Kit is an extensible PHP command-line tool for converting source content and metadata into packages suitable for importing into Islandora (or other digital repository and preservations systems).
GNU General Public License v3.0
34 stars 11 forks source link

Change metadata manipulators in OAI toolchains to manipulate entire XML document #441

Open mjordan opened 6 years ago

mjordan commented 6 years ago

Currently, the OaiToDc and (new in the issue-439 branch) OaiToMods metadata parsers' applyMetadatamanipulators() method acts on XML snippets. This is probably because the code was simply copied from CONTENTdm toolchains (by me 🤕). Since the OAI toolchains harvest complete DC or MODS XML documents, metadata manipulators used in those toolchains should act on the complete XML document. We have already implemented "complete document" metadata manipulators in the Templated toolchain.

I'll wait until #440 is merged and open a PR to address this, unless there's a good reason not to.