Closed jonathangreen closed 6 years ago
Totally. Sorry we didn't catch this earlier. We already use Twig templates so maybe providing a config option to point to one of those is a possible solution.
No worries! Just wanted to make a ticket to note it, since i just stumbled upon it. A small twig template makes sense to me.
I think we already have the solution to this problem in https://github.com/MarcusBarnes/mik/wiki/Metadata-manipulator:-InsertXmlFromTemplate. We should just remove the include_migrated_from_uri
.ini option and document how to add the following snippet:
<identifier type="uri" invalid="yes" displayLabel="Migrated From">http://contentdm.example.com/cdm/ref/collection/foo/id/{{ ID }}</identifier>
Note: we would also need to remove https://github.com/MarcusBarnes/mik/blob/master/src/metadataparsers/mods/CdmToMods.php#L163-L172.
@jonathangreen If I opened a PR for this would you be able to test?
Yikes, found #176 while sifting through old issues to close.
@mjordan I can close this as a duplicate if you want? I am also willing to test.
@jonathangreen yes please, close this one. I'll pick up the work over at #176. Will have something for you to test this week.
Duplicate
[sorry, I posted a comment here that was meant for #176. I then deleted it and posted it there :face_with_head_bandage: ]
Looks like the migrated from URI is currently hard coded to contain
http://content.lib.sfu.ca/cdm/ref/collection/
: https://github.com/MarcusBarnes/mik/blob/master/src/metadataparsers/mods/CdmToMods.php#L169Be nice to be able to override that with your own CDM url.