search

MarcusBarnes / mik

The Move to Islandora Kit is an extensible PHP command-line tool for converting source content and metadata into packages suitable for importing into Islandora (or other digital repository and preservations systems).
GNU General Public License v3.0
34 stars 11 forks source link

Fix broken images in README, wiki, etc. #468

Closed mjordan closed 6 years ago

mjordan commented 6 years ago

In the main README and elsewhere, we (meaning mostly I) have linked to images served from Dropbox. These have not worked in some time, since Dropbox changed its public linking policy. We should move these images off Dropboxy and host them on Github directly. On approach I have heard of is to open a issue and attach the images. They will then be sharable across source files, READMEs, wikis, etc. Or, we could add an images directory to the mik repo and put them there. Some of these images are reused from other pages, however. Thoughts?

MarcusBarnes commented 6 years ago

I haven't tested this, but since wiki's are also repos, it may be possible to clone the wiki locally, add a directory like "images/" with the images, push the changes, then use the links to the images in the wiki repo image folder.

MarcusBarnes commented 6 years ago

I can create a test repo. with a wiki to confirm that this works or not.

MarcusBarnes commented 6 years ago

Here's a test repository with a demonstration on how to do this within the wiki repository: https://github.com/MarcusBarnes/repo_wiki_images_test/wiki. One nice thing about this is that any image assets would be bundled inside the wiki repository, so that one can clone the repository without having to get the images assets elsewhere.

mjordan commented 6 years ago

Nice. I can do some work on this over the weekend. That would entail:

I say 'files' since we also have some non-image assets like the tutorial data. How does all that sound?

MarcusBarnes commented 6 years ago

Sounds excellent! Thank you for taking on this task.

mjordan commented 6 years ago

Works great. I've moved all of the images and the .zip data for the Tutorial into an 'assets/mik_tutorial' directory in the wiki, updated the links in the text of the tutorial page, and it looks good: https://github.com/MarcusBarnes/mik/wiki/Tutorial

Will move on to others soon and will open a PR for fixes to the main MIK README.md file.

mjordan commented 6 years ago

grep -r dropbox * in the wiki code and in MIK's src directory show no more references to those images. Should be good to go other than the main README, which I addressed in PR #472.

MarcusBarnes commented 6 years ago

Thank you again @mjordan for fixing the images in the wiki and the README.