What does this Pull Request do?

Restores --limit functionality to the CSV fetcher.

What's new?

Added a check in mik to break out of its foreach loop at the appropriate place if --limit is set.
Cleaned up logic within the CSV fetcher's getRecords() function.
Added a PHPUnit test to test --limit.
Modified mik to adhere to PSR2 and added its check to .travis.yml.
Added tests directory to PSR2 check in .travis.yml.
Updated the version of the League CSV library from 7.x to 8.x. 8.2.3 is now the oldest stable version (but even it is no longer supported - see http://csv.thephpleague.com/.

Check out the issue-455 branch.
Run composer update or equivalent on your system.
Using the attached zip file, run mik using a variety of values for --limit. Verify in your output directory that the desired number of packages were created.
Run mik using no --limit option. It will create 20 packages.
Within the mik directory, run phpunit. PHPUnit should report Tests: 58, Assertions: 84, Skipped: 2..

Does this change require documentation to be updated? No
Does this change add any new dependencies? Yes, league/csv verision 8 or higher. Run composer update to upgrade this library.
Could this change impact execution of existing code? Yes.

@bondjimbond @MarcusBarnes

bondjimbond commented 6 years ago

Note that I don't have phpunit, so can't test using that. @MarcusBarnes can you give that a try?

mjordan commented 6 years ago

@bondjimbond PHPUnit is installed by MIK. What happens when you run phpunit in the MIK directory?

bondjimbond commented 6 years ago

@mjordan Command not found.

bondjimbond commented 6 years ago

@mjordan Just had a call with @MarcusBarnes; he walked me through it. Turns out I just had to call it in the /vendor/bin directory.

Test result = all clear; mergeable.

mjordan commented 6 years ago

@bondjimbond sweet, and your manual (non-PHPUnit) tests all passed too?

Edit: Sorry, I see that they did.... :smile:

mjordan commented 6 years ago

FYI, Just ran MIK in this branch in Windows and it all worked as intended. Not that it should matter....

mjordan commented 6 years ago

@bondjimbond feel free to merge and close #445. Thanks for testing!