MarcusBarnes / mik

The Move to Islandora Kit is an extensible PHP command-line tool for converting source content and metadata into packages suitable for importing into Islandora (or other digital repository and preservations systems).
GNU General Public License v3.0
34 stars 11 forks source link

Reduce repetition in .ini files #479

Open bondjimbond opened 5 years ago

bondjimbond commented 5 years ago

In many .ini files there are places where the same data needs to be repeated in different sections. For example, in the CdmCompound toolchain, you need to put the CDM webservices URL in FETCHER, METADATA_PARSER, and FILE_GETTER.

Similarly, you need to put the alias in four sections: FETCHER, METADATA_PARSER, FILE_GETTER, and WRITER.

If you work from a template, it's pretty easy to screw this up by forgetting to change it in one place. Could these variables not be set in a single spot in the ini file, and references repeatedly by the different pieces?

MarcusBarnes commented 5 years ago

Similar to issue https://github.com/MarcusBarnes/mik/issues/107.