search

MarcusBarnes / mik

The Move to Islandora Kit is an extensible PHP command-line tool for converting source content and metadata into packages suitable for importing into Islandora (or other digital repository and preservations systems).
GNU General Public License v3.0
34 stars 11 forks source link

Creates root output directory if it does not exist. Addresses issue #457. #489

Closed MarcusBarnes closed 5 years ago

MarcusBarnes commented 5 years ago

Creates the root output directory if it does not already exist for the CSVBook writer. Addresses issue #457.

Github issue: https://github.com/MarcusBarnes/mik/issues/457

What does this Pull Request do?

Adds a call to the createOutputDirectory method in the CSVBook writer so that the root output directory is created if the output directory currently doesn't exist, matching the behaviour of other CSV toolchain writer classes.

How should this be tested?

This will require a smoke test, following the comments in the original issue https://github.com/MarcusBarnes/mik/issues/457. Test both when the output_directory in the config has been created before running MIK and also when it has not been created.

Interested parties

@bondjimbond

MarcusBarnes commented 5 years ago

@bondjimbond It would be great if you would please test this pull-request when you have a moment. Thanks!

bondjimbond commented 5 years ago

@MarcusBarnes Do we have a waiting period after approval for MIK pulls, or should I just merge?

mjordan commented 5 years ago

@bondjimbond no waiting period, go ahead and merge.

MarcusBarnes commented 5 years ago

@bondjimbond At this time we can merge. If the community around MIK gets large enough where merging certain things may become contentious, we can add a process to deal with alternative opinions around approved pull-requests.