search

MarcusBarnes / mik

The Move to Islandora Kit is an extensible PHP command-line tool for converting source content and metadata into packages suitable for importing into Islandora (or other digital repository and preservations systems).
GNU General Public License v3.0
34 stars 11 forks source link

Change include_migrated_from_uri to accept a URI and remove hard-coded SFU URI #491

Closed bondjimbond closed 5 years ago

bondjimbond commented 5 years ago

Github issue: #485

What does this Pull Request do?

Changes the behaviour of the include_migrated_from_uri parameter. Now the user should enter the base URI for their CDM collection. To not include a "migrated from" URI, leave it the value blank.

Possible issue: The line is required (MIK won't run properly without it). I don't know how to make it not required.

Documentation change needed: If there's no fix to make it not required, then some change to the documentation must reflect this. Plus of course we need to fix the documentation anyway to describe the new behaviour.

How should this be tested?

  1. Run a CDM migration .ini file
  2. Include the line include_migrated_from_uri = TRUE
  3. Observe SFU base URL in your identifier tag
  4. Check out this branch
  5. Change line to include_migrated_from_uri =
  6. Run MIK
  7. Observe no "migrated from" identifier
  8. Add a URI like include_migrated_from_uri = http://deck.cs.athabascau.ca/cdm/ref/collection/
  9. Run MIK
  10. Observe the new URI appearing in the metadata

Additional Notes

It would be nice if someone could point out how to make MIK accept the variable not existing at all, instead of having to include an empty value in the .ini file.

Interested parties

@MarcusBarnes @mjordan

mjordan commented 5 years ago

@bondjimbond I am travelling at the moment but can test this over the weekend. Thanks!

bondjimbond commented 5 years ago

@mjordan Did you get a chance to test this?

mjordan commented 5 years ago

No, sorry, I'll make some time to test it today.

mjordan commented 5 years ago

Tested and works as advertised. Thanks @bondjimbond for doing this. Can you update the include_migrated_from_uri option documentation on all the Cdm toolchain wiki pages?