MarcusGitty / pe

0 stars 0 forks source link

Error Message For Edit Command Can be Clearer #2

Open MarcusGitty opened 2 months ago

MarcusGitty commented 2 months ago

How to reproduce the bug:

Type in edit i:0 n/pap

Issue: Index should be a positive integer.

image.png

A more specific error message could be, the index you have entered is not a positive integer instead of invalid command format.

Cuz technically, the command format follow the format, just that the index is invalid. So perhaps the error can be like this, saying the index is invalid

image.png

soc-pe-bot commented 2 months ago

Team's Response

Error message specified positive integer is needed.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Inconsistent error messaging for index query

image.png

image.png

The error message is inconsistent even though both should be similar (index out of bounds)


[original: nus-cs2103-AY2324S2/pe-interim#2855] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Severity should be very low as it does not affect usage, both error message prompts the user to enter the valid command.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The original bug is talking about the consistency of error message while i'm reporting the specificity of it


## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** [replace this with your reason] This is regarding the Specificity of error message and as per the course website it should be a feature flaw. ![image.png](https://raw.githubusercontent.com/MarcusGitty/pe/main/files/b804be38-33a6-434d-beed-842f5012ce43.png)
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** As per the course textbook "Calling an invalid value a 'format error' and vice versa is a severity.Low bug" this is such a case, therefore it should be severity.Low ![image.png](https://raw.githubusercontent.com/MarcusGitty/pe/main/files/b07d601c-2970-4b01-b974-471b45f4ede3.png)