soc-pe-bot
commented
2 months ago Team's Response
"No student found" is a valid error message, because no student will have an invalid student ID/email due to it being checked for during add/edit commands.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Edit doesn't check for validity of inputted Student ID
The edit command doesn't check for invalid format of Student IDs when querying
Steps to reproduce: Input - edit s:A123456M n/Alex This student number is only 6 digits
[original: nus-cs2103-AY2324S2/pe-interim#2857] [original labels: severity.Low type.FeatureFlaw]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
"No student found" is a valid error message, because no student will have an invalid student ID due to it being checked for during add/edit commands.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [x] I disagree
Reason for disagreement: This is a different bug from the one in the original, this is about the consistency of the error messages.
## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** The error message should be consistent for invalid unique identifiers
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
Summary: I tried editing with invalid student identifiers and encountered different error messages for each of them. I suspect that this is due to the input being validated for index and telegram handle but not student and email.
This should have a severity of medium as the user could've inputted a typo for email and studentid and can't find out what went wrong.
To reproduce: edit e/a n/na edit s/a n/na edit i/a n/na edit t/a n/na
Expected behaviour:
All of their error message should say that the unique identifier is invalid, and to enter a valid one, either that or all of them should output No Student Found to be consistent.