search

MarcusOtter / APOD.Net

An unofficial .NET wrapper for NASA's Astronomy Picture of the Day API.
https://marcusotter.github.io/APOD.Net/
MIT License
9 stars 2 forks source link

Make StringBuilder local var instead of member #20

Closed MarcusOtter closed 4 years ago

MarcusOtter commented 4 years ago

I was wrong about #18 having to do with objects not being disposed of correctly. The problem was that the ApodUriBuilder preserved the instance of the StringBuilder between requests, and since the URI was appended to the StringBuilder every time the URI was doubled which obviously did not work. This has been fixed by making the StringBuilder a local variable that is instantiated when the method is called.

Closes #18

github-actions[bot] commented 4 years ago

Coverage Status

Coverage remained the same at 61.244% when pulling 77dcd85c37111c32afc83a21a2ed55ad0cc2c0fb on #18-fix into 92e5c1437a2ece497233d0db659278f66b4236f9 on master.