github-actions[bot]
commented
4 years ago Pull Request Test Coverage Report for Build a5ec23662dd79eb45d255b28f0734e2ce69ad964-PR-8
- 22 of 167 (13.17%) changed or added relevant lines in 9 files are covered.
- 8 unchanged lines in 1 file lost coverage.
- Overall coverage decreased (-72.6%) to 9.825%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| src/Apod/Logic/DefaultsFactory.cs | 0 | 5 | 0.0% | ||
| src/Apod/Entities/ApodError.cs | 0 | 6 | 0.0% | ||
| src/Apod/Entities/ApodResponse.cs | 0 | 7 | 0.0% | ||
| src/Apod/Logic/Errors/ErrorBuilder.cs | 0 | 14 | 0.0% | ||
| src/Apod/ApodClient.cs | 0 | 23 | 0.0% | ||
| src/Apod/Logic/Net/HttpRequester.cs | 0 | 29 | 0.0% | ||
| src/Apod/Logic/Errors/ErrorHandler.cs | 0 | 30 | 0.0% | ||
| src/Apod/Logic/Net/HttpResponseParser.cs | 0 | 31 | 0.0% | ||
| <!-- | Total: | 22 | 167 | 13.17% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| src/Apod/ApodClient.cs | 8 | 0.0% | ||
| <!-- | Total: | 8 | --> |
| Totals | |
|---|---|
| Change from base Build fbf633bb8c8f8e6b7e189cbef914b95c3c15ff3c: | -72.6% |
| Covered Lines: | 22 |
| Relevant Lines: | 183 |
This will rewrite the majority of the library and make it follow the dependency inversion principle, which in turn makes it friendly for dependency injection users. I am in the process of rewriting the unit tests but will merge to easier track my progress.
Closes #1 Closes #2 Closes #5 Closes #6