search

MarcusTXK / pe

0 stars 0 forks source link

Add person to group wrong message #4

Open MarcusTXK opened 2 years ago

MarcusTXK commented 2 years ago

Expected:

Message should state index provided is invalid:

image.png

This is true for all other indexed based commands, but I will not create duplicates for all commands as I feel it is unnecessary and spammy as the root cause is the same.

Actual:

Even though -1 is an integer, and the command format is valid, the app states that the command is invalid instead of warning the user that the index is invalid. The message is hence inconsistent and can be confusing.

image.png

Steps to reproduce:

Input person -1 /add g:Orbital

nus-pe-bot commented 2 years ago

Team's Response

The problems can only happen in case of deliberate sabotage

No one would check for a negative integer unless they were trying to find bugs

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The given index is still invalid, so there is no reason to display that the command format is invalid instead (which is erroneous and confusing, as the command format is correct). The user should be informed the index that is invalid.

The argument that no one will enter this input is flawed. Both 999999999 and -1 are equally invalid index inputs. The purpose of the error message is to guide a user to input the correct command and having inconsistent (or in this case wrong) error messages can lead to inconvenience to the user as they will be unsure what went wrong. As a user, I might not know which part of the command went wrong as it merely states an invalid command format is used.