MarcusTXK / pe

0 stars 0 forks source link

Unable to add people with uncommon names and Wrong error message displayed #7

Open MarcusTXK opened 3 years ago

MarcusTXK commented 3 years ago

Expected:

Actual:

Steps to reproduce:

Enter person X Æ A-12 /create p:91119111 e:notor@notor.com t:Loves Dancing g:1

Screenshots:

image.png

nus-pe-bot commented 3 years ago

Team's Response

Specificity of error message: Error messages can be correct but not specific enough (e.g., it says the input is 'invalid' without giving the reason, or gives too many possible reasons without pointing out the specific reason). These cases can be considered type.FeatureFlaw unless making it more specific will take a lot more effort, in which case there is a chance to argue it to be response.NotInScope.

1) it is stated that names should be alphanumeric with spaces/dash/and fullstop. Hence it is clearly not supported.

2) due to the special characters, it will take a lot more effort to correctly give a more specific error message in the parser

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I am unable to find the source of the quoted text, but even then, it does not take much additional work. In fact, the original AB3 does a simple validation using a regex to check if it meets the requirements and has an error message to inform the user that the name is invalid. This makes this product inferior to AB3 in this regard.

In the UG, at no point, it is stated to the user that the names should be alphanumeric with spaces/dash/and full stop. Below is the only requirement stated in the UG: image.png

As a user, I have no way of knowing why the above command entered is rejected, since:

  1. The name requirement is not stated anywhere (I will not know that it is invalid in the first place)
  2. The error message is extremely generic and merely states it is an invalid command format (which is wrong as the command format entered is correct). I will not know what is wrong with the command entered and may not guess it is due to the name.

This will lead to inconvenience to the user and is hence a valid bug.

Evidence

Screenshot of the original AB3 informing the user what they expect of the name when an invalid name (X Æ A-12, the same as the one used in the issue above) is entered. image.png


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: I am unable to find the source of the quoted text, but even then, it does not take much additional work. In fact, the original AB3 does a simple validation using a regex to check if it meets the requirements and has an error message to inform the user that the name is invalid. This makes this product inferior to AB3 in this regard.

In the UG, at no point, it is stated to the user that the names should be alphanumeric with spaces/dash/and full stop. Below is the only requirement stated in the UG: image.png

As a user, I have no way of knowing why the above command entered is rejected, since:

  1. The name requirement is not stated anywhere (I will not know that it is invalid in the first place)
  2. The error message is extremely generic and merely states it is an invalid command format (which is wrong as the command format entered is correct). I will not know what is wrong with the command entered and may not guess it is due to the name.

This will lead to inconvenience to the user and is hence a valid low bug.

Evidence

Screenshot of the original AB3 informing the user what they expect of the name when an invalid name (X Æ A-12, the same as the one used in the issue above) is entered. image.png