MarcusWolschon / osmeditor4android

Vespucci is a OpenStreetMap editor for Android
http://vespucci.io
Other
378 stars 83 forks source link

Just like browser history, have changeset history #2021

Open jidanni opened 1 year ago

jidanni commented 1 year ago

After we upload our changes, momentarily at the bottom of the screen a green message appears saying upload successful.. Well, on the side it should perhaps also have a link that we could press in case we want to copy the URL to our changeset.

Also, somewhere in the app, a few links to recent changesets we made could perhaps be available, in case we want to refer to one of them. Maybe they could be listed along with the times they occurred.

Sure, you might say all that is nicely already available at https://www.openstreetmap.org/user/jidanni/history , but I think the app should hold on to those important changeset numbers for a little while after we make them anyway. Maybe just keep the most recent pageful, about 10.

I'm not sure what to call a menu item for this. Changesets? Upload History?

simonpoole commented 1 year ago

Sure, you might say all that is nicely already available at https://www.openstreetmap.org/user/jidanni/history ,

Well the thing is, retaining changeset history would only be useful in any case if you have internet connectivity, and if you have that you could just as well go to the website. So you would need to give some more motivation why you would want to retain them.

jidanni commented 1 year ago

Okay, at least I got one killer reason to remember the changeset number that we just got, at least for a few seconds while the message that the upload was successful is shown. The killer reason is:

Saying "upload successful" is great, but saying "upload successful: changeset #333333..." offers "real proof" that it was successful. And in fact that could be a hyperlink too.

In fact that's how the iD editor operates.

simonpoole commented 1 year ago

Saying "upload successful" is great, but saying "upload successful: changeset #333333..." offers "real proof" that it was successful. And in fact that could be a hyperlink too.

Changesets ids are allocated pre-upload. Displaying the changeset number indicates literally nothing.

In fact that's how the iD editor operates.

Doesn't make it less meaningless.

jidanni commented 1 year ago

I was just thinking it's sort of like when you submit your tax form. The government responds with the receipt number.

At least it's better than sending something and not knowing if they ever got anything.

It doesn't have to mean they like what you sent or not. Just proof at least something went through to the other side.

simonpoole commented 1 year ago

The not Vepsucci specific logic is (assuming we are not leaving changesets open)

after that you get the success message from the app, if anything goes wrong in any of the three steps you will get an error. In any case as said the id is allocated before anything interesting happens and it in itself is not an indication of a successful upload. As you probably know, and I allured to this above, you don't even have to close changesets, in principle you can add as many uploads as you want to one.

jidanni commented 1 year ago

Well, okay, I just thought that it would "prove" that we really got connected to the site at least. But okay I guess you know more about this than I do. So I'll just remove this wish list item.

jidanni commented 7 months ago

Actually, it would be very convenient for the app just to remember the latest five etc. changeset numbers we created.

I'm not saying all the changsets that we created across all the apps including iD. I'm just saying the ones that we created by this app.

Otherwise one has to go to OSM.Org, and click and click and click to finally getting to https://www.openstreetmap.org/user/jidanni/history .

Which in fact doesn't have them sorted by editor app anyway.

Just like some users often check their browser's history, e.g., chrome://history/ .