search

MarcusWolschon / osmeditor4android

Vespucci is a OpenStreetMap editor for Android
http://vespucci.io
Other
382 stars 83 forks source link

Modify location and compass direction of photos #2309

Open contrapunctus-1 opened 1 year ago

contrapunctus-1 commented 1 year ago

Frequently, the GPS and compass direction in (local) geotagged photos are inaccurate. It would be great if I could correct these properties in Vespucci, while I'm on the ground.

It is arguable whether Vespucci is the right application for this. On one hand, this is the ambit of a photo editor rather than a map editor. On the other hand, Vespucci already has the necessary ingredients for such a tool, i.e. it displays the photos and compass direction on a map. And it's mappers who are most likely to want to make these modifications.

contrapunctus-1 commented 1 year ago

To be able to do this on the ground probably also requires that Vespucci display photos as soon as they are shot, rather than requiring a restart of the app or toggling the photo layer.

contrapunctus-1 commented 1 year ago

To be able to do this on the ground probably also requires that Vespucci display photos as soon as they are shot, rather than requiring a restart of the app or toggling the photo layer.

Actually, if Vespucci were to do "just" this alone, it would let mappers know that their photo location/angle is off, and they could attempt to take the picture again.

simonpoole commented 1 year ago

Actually, if Vespucci were to do "just" this alone, it would let mappers know that their photo location/angle is off, and they could attempt to take the picture again.

I would note that if the layer is on, the photo icon is added immediately.

contrapunctus-1 commented 1 year ago

I realized later why Vespucci wasn't displaying the photos immediately - it's because I wasn't taking them with Vespucci's camera button.

The downside of using Vespucci's camera button is that photos are saved in Download/Vespucci/Pictures/ instead of DCIM/OpenCamera/, and their file names use UTC timestamps rather than local time.

If (when using Vespucci's camera button) the photo file names could use local timestamps (and ideally saved in the camera app's save directory), and/or Vespucci could watch the filesystem for new geotagged photos and update the photo layer automatically, this issue could be resolved without adding any photo-editing functionality.

simonpoole commented 1 year ago

There is "no watching the filesystem" in modern Android versions. If the picture is added to the media store, and media store indexing is turned on then the photo should (should as in: it works on my Android 13 device using Open Camera) be added automatically.to the photo layer. You can test this by simply taking a photo with OC while Vespucci is in the background.

I could make saving in the Vespucci directory configurable, but disabling that comes with other disadvantages, for example you then can't delete photos from the photo viewer, see https://github.com/MarcusWolschon/osmeditor4android/issues/1913 for that problem the other way around.