MarcusWolschon / osmeditor4android

Vespucci is a OpenStreetMap editor for Android
http://vespucci.io
Other
358 stars 83 forks source link

GUI questions regarding the preset item “Payment methods“ #2546

Open jajajaneeneenee opened 2 months ago

jajajaneeneenee commented 2 months ago

If I choose the preset “Payment Methods“ for an item where it is added by a preset link, I get a long list of payment method keys (as check elements). That's fine – but it's very long and therefore a bit confusing, especially because it has no structure.

When I looked in the preset code, I was surprised, because there are some very useful <space/> lines there – which are or should be supported since Vespucci v20.0.0 (which I really appreciate!). E.g. before the “blocks“ for debit cards, credit cards, contactless payments and so on. So a structure already exists ...

But the <space/> lines seem not to work in this case – perhaps because it's only a preset link item? (Then it will probably affect also other items).

And something else doesn't seem to be supported here: I simply tried to insert a few lines with <label text="XY" /> for structuring (e.g. <label text="Credit Cards:" /> at the beginning of this block). ... and hoped this could be a workaround (I used this method in my custom presets before <space/> was supported by Vespucci – and with <label text=" " /> – with a non-breaking space character – you can even create an empty looking line like <space/> does). But no – these are not displayed either.

Could this perhaps be improved? So that <space/> + <label text="XY" /> also works here? (And <item_separator /> – I didn't try that.) I think it would be particularly useful for this item and improve the GUI!

And I had another surprise: when I tested a node that was somehow tagged (matching with an item without a preset link to "Payment Methods"), the payment keys were not displayed with checkboxes, but like normal text elements (with “Type Value“ in the “Properties” tab of the editor). Can this behaviour also be changed/optimized? (So that it is also displayed here as a check element? At least after selecting the preset in the editor.) Maybe you want to use it for something where it isn't added as a preset link ... Not as important as what was previously described, I just wanted to mention it.

simonpoole commented 2 months ago

And I had another surprise: when I tested a node that was somehow tagged (matching with an item without a preset link to "Payment Methods"),

To start with this, this shouldn't be a surprise as this is simply a tag that can't be associated with a preset as there is no linked preset, and the preset contains any additional formatting information.

As to the the 1st issue: this is not simple to resolve as there are two competing demands here on the one hand not wanting to apply the whole linked preset just because their is one key from it present on the object, on the other hand the formatting only makes sense when the full preset has been added.

jajajaneeneenee commented 1 month ago

To start with this, this shouldn't be a surprise as this is simply a tag that can't be associated with a preset as there is no linked preset, and the preset contains any additional formatting information.

I understand it basically on a pure technical basis (as it is now).

But I was hoping (or had the idea) that there was a way that the formatting information from the “Payment Methods” preset (keys as check elements) contained there could be taken into account for the display in the editor after selecting this preset, regardless of whether there is preset matching. Just for the display as long as you are in editing mode of the object for which you have selected the preset. But it apparently contradicts too much the technology of how the editor works. In any case, it would still be desirable...

As to the the 1st issue: this is not simple to resolve as there are two competing demands here on the one hand not wanting to apply the whole linked preset just because their is one key from it present on the object, on the other hand the formatting only makes sense when the full preset has been added.

The same thing applies to me here as what I said above ... It's unfortunate that there doesn't seem to be any way to subdivide this very confusing “Payment Methods” preset using blank lines. I wouldn't have thought that there wouldn't be a solution for this ... or that it would require too big of a change. It's just unfortunate that you have to deal with such a confusing list. Is there really no way?

To be clear: I'm not talking about the preset being permanently assigned to the object with all keys, but only about being displayed in the editor at the moment you selected it for the current editing action. That's what it's all about – making it look clear at that moment.