search

MarcusWolschon / osmeditor4android

Vespucci is a OpenStreetMap editor for Android
http://vespucci.io
Other
378 stars 83 forks source link

Crashes when backing out from editing multiselection #422

Closed tweejee closed 8 years ago

tweejee commented 8 years ago

Because I was requested in the app to submit an issue when a crash happened repeatedly: here it is. I'll try to document it, but if more info is needed please contact me.

Actions that caused the crash: Open Vespucci from OsmAnd. Select a way. Choose menu > Extend selection. Select another way. Choose Edit tags. Hide keyboard. Tap "back" softkey.

Result: Vespucci restarts. In message centre a message "Vespucci has crashes or..." appears.

Device: Sony Experia Z2 (D6503). Android Lollipop. System and app up to date.

simonpoole commented 8 years ago

Most important information would be which Vespucci version you are using (visible at the top of the advanced preferences). Did you send in the crash dump?

tweejee commented 8 years ago

Version is 0.9.7r1093. And yes, I did send in three crash dumps.

Please let me know if there's anything else I can help with.

simonpoole commented 8 years ago

Yes found the crash dumps now. The issue may have already been fixed (can't recreate it right now), where the ways in question members of a relation? See https://github.com/MarcusWolschon/osmeditor4android/commit/f1a826a1c7b7a83c32f23dfdbdbd67d484819df0

tweejee commented 8 years ago

Yes, the ways in question are members of different relations. And selecting the relations themselves causes the same issue.

simonpoole commented 8 years ago

Can't recreate the issue with the current maintainance branch, so likely it was fixed as mentioned. A new build of that is waiting to be pushed to the google playstore in any case and will be available as soon as Marcus gets to it.I'll leave the ticket open till the fix is confirmed.

Note on the side: double tapping an element will start the "Extend selection"/Multi-Select mode too, a bit faster and easier to use likely.

tweejee commented 8 years ago

Thank you.

And let me take the opportunity to say how much I appreciate Vespucci.