search

MarcusWolschon / osmeditor4android

Vespucci is a OpenStreetMap editor for Android
http://vespucci.io
Other
376 stars 83 forks source link

unable to update a MapRoulette task status? #823

Closed govvin closed 5 years ago

govvin commented 5 years ago

Vespucci Version

12.0.0 Beta 3

Download source

Github

Device (Manufacturer and Model)

Google Pixel XL

Android Version

9

Behaviour/Symptoms

When I change the state of the ask (from Open to Closed) , press save (should i?) then hit the Upload button, it seems to keep on failing to upload and Vespucci keeps asking me for the API key. On my first try, I did paste the API key, but the change did not reflect on the MR task I was working on, so I retried. Task is still open, but unable to change the status within Vespucci

Expected Behaviour

Should be able to update the Task status. App should not ask for the API key again. If there was an error, a more helpful message is welcome.

How to recreate

  1. Find a suitable task in your favorite or familiar neighbourhood. Download the available tasks.
  2. Work on the task and upload to OSM
  3. Update the the task status, and upload to MR.

Crash dump submitted (no or yes + date)

no

simonpoole commented 5 years ago

Can you query https://api.openstreetmap.org/api/0.6/user/preferences and see if it contains the correct maproulette key? If it doesn't, could you try adding it via the tool menu? And then re-check?

simonpoole commented 5 years ago

@govvin btw the maproulette tasks work just the same as Notes, Osmose bugs etc, save will just save locally, for upload with any other tasks that have changed status later on. "Upload" will save and upload immediately.

govvin commented 5 years ago

First time I checked, the MR key wasn't there, so I tried to add it via the tool menu. After doing so, without any obvious errors, I queried the API again, but didn't find the MR key.

I tried to reauthorize, the app, just in case, that would help, but it didn't. The MR key is not found in my user preferences.

Can you query https://api.openstreetmap.org/api/0.6/user/preferences and see if it contains the correct maproulette key? If it doesn't, could you try adding it via the tool menu? And then re-check?

simonpoole commented 5 years ago

@govvin that sounds super weird. Are you using the standard API entry? (and do you have any other entries in the preferences?)

govvin commented 5 years ago

I wouldn't know what "standard" would look like. I do have a lot of Overpass IDE query keys, but nothing for MapRoulette or Vespucci.

@govvin that sounds super weird. Are you using the standard API entry? (and do you have any other entries in the preferences?)

simonpoole commented 5 years ago

@govvin seems as setting the key has stopped working for me too. Investigating that.

simonpoole commented 5 years ago

OK, problem understood. @gravitystorm has been doing some refactoring and bug fixing on the OSM API which overlapped the development of this feature. In other words it used to work and stopped after some (needed) API changes.

You simply need to re-authorize the app again now (I had to change the OAuth settings for Vespucci), and it should work as designed (see https://github.com/MarcusWolschon/osmeditor4android/commit/6e463fffd01ad639345b009afe44a48212e25193 ),

https://github.com/MarcusWolschon/osmeditor4android/commit/b6ac50656c75cf889c18a2340702488e5098439d contains some improvements to the feedback when setting the key.