Mardak / enterSelects

Press enter in the AwesomeBar to select the first result (without pressing down)
8 stars 3 forks source link

Doesn't select website's root even when it should #12

Open pintassilgo opened 8 years ago

pintassilgo commented 8 years ago

Until Firefox 47, it was smart to know when to select an internal page (e.g. "fi" was selecting "https://www.reddit.com/r/firefox/") and when to select the website index (e.g. "gl" was selecting "http://globoesporte.globo.com/").

Now, in Firefox 48, with the "Visit/Search ..." thing always being the first entry and Enter Selects skipping to the second, I'm no longer able to open website's root by typing some chars then Enter (like "fa"+Enter to loads just facebook.com). Now I need to type, PRESS UP KEY then Enter.

One workaround is to turn off autofill (browser.urlbar.autoFill=false). But this way I lose the ability to quickly fill the hostname to open not so common internal pages (e.g. with autofill activated, until Fx 47 I could type "gi" + End key (or right key) to fill "https://github.com/" and then type a username or project; without autofill I need to type the entire hostname - "github.com/" - first).

Mardak commented 8 years ago

How would you differentiate between typing "fi" to select "https://www.reddit.com/r/firefox/" vs "Visit fidelity.com" (similar to your "fa" -> facebook.com situation pretending you've visited fidelity.com)?

Mardak commented 8 years ago

For some more Firefox behavior context, the "Visit " entry will prevent the second entry to be duplicated if it would have been the same page. For my own browsing profile, I've hacked around this by going to "https://www.facebook.com/?" (note the trailing "?" is important) so that it shows up as the second item, so that Enter Selects will use that one.

pintassilgo commented 8 years ago

How would you differentiate between typing "fi" to select "https://www.reddit.com/r/firefox/" vs "Visit fidelity.com" (similar to your "fa" -> facebook.com situation pretending you've visited fidelity.com)?

Probably this: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/Places/Frecency_algorithm

That is, if I accessed redditFirefox more times than Fidelity, if I accessed more recently, if I manually selected redditFirefox entry when typed "fi"...

pintassilgo commented 8 years ago

Disabling autofill is the best choice to view the frequency ranking, without the "Visit " thing making hostname matches rise jumping the queue, so that "https://www.reddit.com/r/firefox/" should be preferred over "http://www.fidelity.com/" because I've opened redditFirefox more times and other factors.

But that way I completely lose the option to autocomplete and I don't want it.

The way it was until Firefox 47 was perfect.

pintassilgo commented 8 years ago

Firefox 47.0.1 with Enter Selects 13 and browser.urlbar.unifiedcomplete=false (the perfect behavior, IMHO): fx47

Firefox 48.0 with Enter Selects 14 (bad): fx48

Firefox 48.0 with Enter Selects 14 and browser.urlbar.autoFill=false (workaround, but I miss autocomplete hostname): fx48w