search

Mardak / profile

2 stars 7 forks source link

Recommendation list is too big and varies in length #22

Closed mzhilyaev closed 10 years ago

mzhilyaev commented 10 years ago

Depending on the interests the number of recommended links varies greatly. 1) Interests {Programming:1} - widget display 20 links 2) Interests {Programming:1, Sports:1} - widget displays 12 links 3) Ed says he see a list of 78 recommendations

The number of recommended articles should be 10

oyiptong commented 10 years ago

There is the option to specify the number of results in the API. Please check the headliner docs

Mardak commented 10 years ago

It's a query parameter ?limit=10 (see example https://github.com/oyiptong/up-headliner/blob/master/scripts/example_request.sh )

https://github.com/oyiptong/up-headliner#personalization-api

One simple fix is changing the default preference to include the ?limit=10

mzhilyaev commented 10 years ago

The simple fix suggested by Mardak does not work due to the server bug described here: https://github.com/oyiptong/up-headliner/issues/9 Will instrument an implicit collection of 10 stories in the code.

oyiptong commented 10 years ago

Fixed server-side in https://github.com/oyiptong/up-headliner/pull/12

mzhilyaev commented 10 years ago

We still have to add ?limit=10 to the nytimes_headliner_url in package.json