search

Mardak / profile

2 stars 7 forks source link

Privacy exposing nytimes URL #35

Closed mzhilyaev closed 10 years ago

mzhilyaev commented 10 years ago

this url http://www.nytimes.com/projects/2013/invisible-child/#/?chapt=2 is mapped to "/projects/_NUM/invisible-child/#"

The title is still visible

Mardak commented 10 years ago

The new commits are missing the testcase added in the original commit: https://github.com/Mardak/profile/commit/fc14bfff59d56cc2d7399830ff1c32e3650187a9#diff-1

Mardak commented 10 years ago

And the commit message should describe what's being fixed, e.g., correctly hide article title parts of the url. Use nsIURL to extract the path vs query instead of manually parsing for ?/#.