search

Mardak / profile

2 stars 7 forks source link

Internationalize Consent Page #52

Closed oyiptong closed 10 years ago

oyiptong commented 10 years ago

Before we can localize, e.g. for #43, we need to internationalize the consent page

PinZhang commented 10 years ago

@oyiptong, are you working on this?

oyiptong commented 10 years ago

Yes I am

PinZhang commented 10 years ago

@oyiptong, <a href="#" ng-click="openModalPreview()">view a sample of the data</a> is broken after translated, I think we need to break the paragraph into several parts, instead of keeping <a href="#" ng-click="openModalPreview()">view a sample of the data</a> as part of the text needed translation.

PinZhang commented 10 years ago

Locale file for zh-CN have been pushed to branch pzhang/issue52-zh_CN.

oyiptong commented 10 years ago

I'm looking into it. Thank you, Pin.

oyiptong commented 10 years ago

I think the problem is deeper. Angular-gettext seems to have difficulty compiling the contents of the translated string if it contains certain characters. I'll get deeper into it after I finish some stuff that needs immediate attention