search

Mardaneus86 / futwebapp-tampermonkey

TamperMonkey scripts to enhance the FUT 21 Web App - Discontinued
MIT License
192 stars 103 forks source link

Highlight (color) profitable items in club based on Bought For - Futbin price #122

Open kashefcom opened 6 years ago

kashefcom commented 6 years ago

Expected behavior: When browsing our Club -> Players Items, rows will be colored based on potential profitability. Profitability is calculated as ("Futbin Price" - "Bought For Price") / "Bought For Price" (while +ve).

Current behavior: No coloring is applied at the moment, only futbin prices are shown for each item

Feigenstaub commented 6 years ago

ouh that's interesting, could maybe be made aswell for just browsing through the market?

kashefcom commented 6 years ago

I believe you want to compare futbin price with bin price, an enhancement request has already been opened for that.

Regaddi commented 6 years ago

@kashefcom You're only referring to the club players view, correct? How should we handle players, that haven't been bought e.g. from pack openings? IMO they shouldn't get this highlighting.

kashefcom commented 6 years ago

Yes, no highlighting in that case since they're pack pulled. I would've suggested a neutral color to indicate pack pulled players but since it seems we will have a lot of colored rows I would refrain to avoid any clashes across the app.

Mardaneus86 commented 6 years ago

As I think about it I'd like to refrain from using a lot of colors throughout. It is most useful to the general public for comparing transferlist auctions to Futbin BIN to find "bargains". In all other cases there isn't a time constraint so it may be better to use some sort of icons?

Since the project is about enhancing the UX of the web app, we shouldn't make it worse 😆

kashefcom commented 6 years ago

An icon would be absolutely fine as well, maybe a money icon with a small overlay of the profit alongside it? I suggested color highlighting based on the previous requests and wasn't worried about it clashing since the club players view is separate from the transfer market.

Mardaneus86 commented 6 years ago

Colors were fine when it was just BIN comparison. Now that more features are requested, colors may not be the best approach. Feel free to create a mockup of how you think it could look!

kashefcom commented 6 years ago

Something along those lines possibly?

image