search

Mardaneus86 / futwebapp-tampermonkey

TamperMonkey scripts to enhance the FUT 21 Web App - Discontinued
MIT License
192 stars 103 forks source link

Enforce a coding standard #130

Open Mardaneus86 opened 6 years ago

Mardaneus86 commented 6 years ago

Issue placeholder to enforce a coding standard throughout to project.

Also add proper contribution guidelines for Pull Requests to the Readme and/or repository.

Regaddi commented 6 years ago

Some suggestions from my point of view:

pratik60 commented 6 years ago

I recommend using prettier: https://github.com/prettier/prettier just because it imposes opinion about code formatting, and takes the decision out of developer hands.

Regaddi commented 6 years ago

@pratik60 I don't think there is much need for prettier since the project is already using the even more popular airbnb javascript guidelines.

pratik60 commented 6 years ago

Prettier is great because you don't have to think about the javascript guidelines, as with editor plugins it autosaves it in the right format. Its removes friction from code reviews, or the cognitive overload so that you don't have to think about js guidelines.

Cool to not have it, was just a suggestion.

Regaddi commented 6 years ago

Same applies to the eslint config by Airbnb 😊 On top of code style it contains also rules to prevent code smells

hamishtaplin commented 5 years ago

Definitely consider adding Prettier. I would hate to work on a codebase that doesn't have it nowadays—it's one of those things you don't truly appreciate until it isn't there any more.