DS - Refactor event form

MareikeFla commented 3 months ago

Welcome to the biggest useState Festival this side of the digital ocean!

First of all

The solution shown here contains many useStates. Really many, I know. I came across useReduce during my research and have an irrepressible desire to try it out, HOWEVER I decided to develop this in a separate developer story to make the pull requests clearer.

This PR

I have implemented a logic that prevents the end of an event from being before its start.
I have implemented a logic that makes sure that a street has to be entered if a house number has been entered and a link is required if a link description has been entered.
I have moved all states and help functions into a separate hook.
I added a key to check if an event is free of charge and one to check if an event is an online event
When editing an event long description field has the right size now and short description character count is right
I tryed to improve the readability of the EventForm

Not this PR

I have moved the following output, originally contained in this DS story, to a separate US - Also to make code review easier:

long description should keep paragraphs from the event form long description field
When long description is too long just the first 600 letters are shown followed by "...mehr" which user can select to see the whole text

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
community-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 26, 2024 2:58pm

MareikeFla commented 3 months ago

Thanks @JessicaLoers for your comments and approving! I am totally aware there is a lot of stuff that could be refactored. All I tried to do was to stay with my developer story (There is written down what will be refactored) to keep it structured. That did not work out at all.

JessicaLoers commented 3 months ago

Maybe we coaches drove you a little wild and should've focused more on your dev story. Sorry about that. 🐰

jana-scheidemann commented 3 months ago

Hey Mareike, this is my first QA, please be gentle with me :)

Most of your form fields work as you wish, I added 2 test events, unfortunately both of them have an end time that is before start time - this is not what you wanted.

However it is not possible to select a start date in the past - this is what you wanted. as a stressed user that is not paying too much attention, it would be helpful if the past dates would be greyed out or if an alert appears that informs me that the date is in the past and therefore can not be selected.

The Link is also a bit stressful to handle because it needs the "http://" but doesn't offer it (only as a placeholder which is gone as soon as I enter a url - but then I get an error message).

Otherwise your capstone project looks very nice and crazy complex. I am highly impressed.

MareikeFla / community-app