search

MareikeW / dashboard-project

In this project, we create an app where people can track their productivity over a 12 week period.
4 stars 9 forks source link

Remove the title "minimize" when the button is in minimize mode (goal-form). #21

Closed MareikeW closed 2 years ago

MareikeW commented 2 years ago

When the goal-form is minimized, the title for the button is still "minimize".

kingsbury commented 2 years ago

Can I take this one?

MareikeW commented 2 years ago

Hey, for now, it's only one issue per person. But if in a week nobody else has shown any interest in doing this task, you can do it, if you still want, of course :) Hope you can understand.

kingsbury commented 2 years ago

No worries! Please let me know if anything else opens up. Thanks for opening this up for contributions, my first PR showed up on my Hacktober profile!!

GabeNedden commented 2 years ago

hello, I'd like to give this a try. I think I'll use a ternary operator that checks if show is true or false.

MareikeW commented 2 years ago

Hi, sorry, I hadn't seen this here. Please always wait for me to assign you before sending pull requests.

GabeNedden commented 2 years ago

Hi, now I will assign you to this issue and then you can send a pull request. Please always wait for me to assign you first before doing anything.

Hi Mareike, I think you just taught me a very important lesson about contributing, and I appreciate it!

MareikeW commented 2 years ago

Thank you! It's just that there have already been two other pull requests out of nowhere and I was a bit annoyed about it ;)