Marekkon5 / onetagger

Music tagger for Windows, MacOS and Linux with Beatport, Discogs, Musicbrainz, Spotify, Traxsource and many other platforms support.
https://onetagger.github.io/
GNU General Public License v3.0
624 stars 33 forks source link

Search BPM Supreme #112

Closed bladerelic closed 2 years ago

bladerelic commented 2 years ago

is there any way to query results from https://app.bpmsupreme.com/search/audio ?

Marekkon5 commented 2 years ago

There isn't currently an option for it in Onetagger.

To my knowledge the service is paid and requires login, so because of that I won't be adding it into 1T. However you can make a custom plugin for it. Also what metadata from there are you looking for? Thanks

bladerelic commented 2 years ago

It is a paid service to download music, but you can create an account for free. The search result includes "Artist" "Title" "Genre" "Publish Date" "Mood" "BPM" & "Key". Where can I go to learn more about creating plugins?

On Sun, May 15, 2022 at 3:01 PM Marekkon5 @.***> wrote:

There isn't currently an option for it in Onetagger.

To my knowledge the service is paid and requires login, so because of that I won't be adding it into 1T. However you can make a custom plugin for it. Also what metadata from there are you looking for? Thanks

— Reply to this email directly, view it on GitHub https://github.com/Marekkon5/onetagger/issues/112#issuecomment-1126997054, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUTBSM5T347BH6KOWHM6PXDVKFCYXANCNFSM5V6GQYOA . You are receiving this because you authored the thread.Message ID: @.***>

--

Marekkon5 commented 2 years ago

Since it is not paid, we might consider adding it to 1T. However it will take few days.

If you want to try making a plugin here's the template and instructions in readme: https://github.com/Marekkon5/onetagger-platform-template/

Marekkon5 commented 2 years ago

Added in latest commit, it works, but it is unfinished (needs description, logo, testing...). You can get the binary from the Actions tab to test it out. Let me know if it works for you. Thanks

bladerelic commented 2 years ago

thanks! i will test it out. i have a ton of files that need tagging!

On Thu, May 19, 2022 at 4:59 PM Marekkon5 @.***> wrote:

Added in latest commit, it works, but it is unfinished (needs description, logo, testing...). You can get the binary from the Actions tab to test it out. Let me know if it works for you. Thanks

— Reply to this email directly, view it on GitHub https://github.com/Marekkon5/onetagger/issues/112#issuecomment-1132203396, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUTBSM6UK5WKTAF247RMRWDVK2TU3ANCNFSM5V6GQYOA . You are receiving this because you authored the thread.Message ID: @.***>

--

bladerelic commented 2 years ago

it appears to work, but i have one little issue. i have a file that goes "Artist - Title (intro clean)". how can i get your app to ignore the "(intro clean) part when doing a search?

Marekkon5 commented 2 years ago

Most (intro) and (clean) parts are removed from search, but not (intro clean). Ill add that tomorrow. For now you can just lower the strictness

bladerelic commented 2 years ago

ah i see. i changed it to (clean) and it works. maybe set up a way to ignore things that are in parentheses. or have an place where people can input what they want ignored?

thanks for your help. i have subscribed to your patreon

bladerelic commented 2 years ago

im also seeing a lot of "HTTP status client error (429 Too Many Requests)" in the log. so maybe slow down how often it searches just like you did with itunes

Marekkon5 commented 2 years ago

In the latest commit I've added BPM Supreme info (description, icon), fixed the rate limit (it should retry on 429 error), moved mood to it's own tag rather than other.

As for the (intro clean) - I've added it there. However your suggestions:

You can get the binary from the Actions tab. Let me know if it works for you. Thanks

bladerelic commented 2 years ago

seems to work well. it was able to identify 258 out of 338 files in my test folder. i'll let you know if i stumble upon any other bugs

Marekkon5 commented 2 years ago

Feel free to comment or open another issue if you have more problems.