search

Marekkon5 / onetagger

Music tagger for Windows, MacOS and Linux with Beatport, Discogs, Musicbrainz, Spotify, Traxsource and many other platforms support.
https://onetagger.github.io/
GNU General Public License v3.0
595 stars 31 forks source link

Onetagger deleting Serato beatgrid/cue points? #121

Closed DJScalf closed 2 years ago

DJScalf commented 2 years ago

After adding tags through OneTagger, a good amount of my tracks (~25%) have completely lost all cue point, beatgrid, and play count information in Serato. When loading tracks, some now load as if I have never used them before and they are being analyzed for the first time.

Songs with 30+ plays will load in at 0 plays -- completely wiped of cues and grids.

In the case of one folder filled with halloween tracks that I tagged as "seasonal" and "niche", every single one has lost its cues and grids.

Is there any rhyme or reason to this or ways I can prevent? I love the product otherwise but I am afraid I am causing more harm than good with this now.

DJScalf commented 2 years ago

Update: I have found a pattern in which ones are affected and which are not:

I get my music from two main sources: BPM Supreme & TheMashup

TheMashup: ALL tracks from here are affected (luckily I have only used OneTagger on very few of these so far)

BPM Supreme: I know their older uploads were not as good with metadata and have gotten better through the years. For tracks from this record pool, it seems that tracks uploaded 2019 or later are unaffected, everything else is wiped of cue points and grids upon loading in Serato

Do you know what might be causing this? I am going to have to stop using OneTagger and begin doing this manually instead. For now, this will save me time of this cue/grid nightmare

Marekkon5 commented 2 years ago

Could you share your log? It might have some useful info about what happened. You can access it using Settings > Open data folder and there is onetagger.log. Thanks

Marekkon5 commented 2 years ago

Should be fixed in the latest commit. You can get binary from the Actions tab to test it out. Let me know if it works for you, feel free to comment or reopen if you have any more issues. Thanks

DJScalf commented 2 years ago

Here is my log. I will see if it has resolved my issues! onetagger.log

DJScalf commented 2 years ago

Also excuse my unfamiliarity with open-source terminology: Do I have to update anything to get the latest commit?

DJScalf commented 2 years ago

If the case is that it auto-updates: I am still having the same exact issue

bascurtiz commented 2 years ago

@DJScalf Do like this:

You don't have to compile it from source. You just have to be logged into Github, then click the Actions tab on top:

image

Then click on the latest commit:

image

There scroll to bottom and you can see the Artifacts section:

image

If you use Windows - click onetagger-win-setup and it will download the Windows Setup version.

DJScalf commented 2 years ago

thanks @bascurtiz ! Very helpful

Good news and bad news:

Good news - Yay! My cue points and beatgrids are still in tact now! Thank you so much! Bads news - play count is wiped upon loading still for the files in question.

Any way to fix that as well?

btw: thank you for all that you do for the DJ community

bascurtiz commented 2 years ago

@DJScalf You're welcome and thank you! I've played around a bit and this is the outcome, see: https://serato.com/forum/discussion/1867961 Can you confirm?

DJScalf commented 2 years ago

yep @bascurtiz that sounds accurate. I wonder if Serato will have anything.

However, this issue still only affects certain files (in my case, old BPM Supreme files and TheMashup files)

bascurtiz commented 2 years ago

Interesting... Could you share such old and a new file (that does not seem to be affected), so I can inspect further? You can attach them here as a zip.

DJScalf commented 2 years ago

Here you go onetagger test songs.zip

DJScalf commented 2 years ago

^ Jimmy Cooks should be unaffected, the other one should be affected

bascurtiz commented 2 years ago

@DJScalf I've found the culprit , updated the topic here: https://serato.com/forum/discussion/1867961

@Marekkon5 also pushed a fix for this to the ID3 library we're using for One Tagger here: https://github.com/polyfloyd/rust-id3/pull/98 We're waiting for the request to be accepted.

Meanwhile, you can get your playcounts back by converting your audio files to either ID3v2.3 ISO-8859-1, or ID3v2.4 UTF-8 using mp3tag.

In order to do so, just click Tools > Options > Mpeg > Write > select ID3v2.4 UTF-8 or ID3v2.3 ISO-8859-1 and hit OK. Now load in all your tracks , select them all (CTRL-A) and hit Save button on top.

image

Meanwhile, while using One Tagger I suggest to Enable ID3v2.4 in Advanced section. Let me know if it fixes all your issues so far.

DJScalf commented 2 years ago

Thanks for all your hard work! Really insightful stuff.

However, I can't find the setting in OneTagger you're referring to:

image

Marekkon5 commented 2 years ago

It's in the AutoTagger advanced sections. Not settings.

DJScalf commented 2 years ago

Ah I see. Thanks! I have really only been using quick tag but I did run a few folders through autotag to get album art, years, etc.

If I understand correctly, will running files through autotag (with ID3v2.4 setting turned on) then using quick tag prevent the playcount issues?

EDIT: After a quick test, my presumption above works! Although, if autotag fails to find a match, it does not. Oh well. Let me know if a future commit fixes this.

Thank you both so much with your help through all of this. I will now resume the painstaking task of retroactively tagging my mess of a library! I will definitely be donating a portion of my next gig check to you guys :) @Marekkon5 @bascurtiz

Marekkon5 commented 2 years ago

Hello, I've assumed you used AT, not QT. My bad.

Anyway in the latest commit I've added the ID3v2.4 option for QuickTag into settings. I've also switched to my fork of rust-id3, so Serato Playcount should be fixed now. You can get the binary from the Actions tab to try it out. Feel free to comment or reopen if you have any more issues.

DJScalf commented 2 years ago

Hey, new issue seems to have surfaced. I tried to manually fix a song's incorrect metadata, and I get this error. It seems I am unable to do anything in the "edit tags" mode without getting this error

image

Marekkon5 commented 2 years ago

We actually already found out and fixed that. Again you can get the latest binary from the Actions tab

bascurtiz commented 1 year ago

Correct. Grab the latest commit from the actions, where this has been fixed.

On Mon, 11 Jul 2022, 03:08 DJScalf, @.***> wrote:

Hey, new issue seems to have surfaced. I tried to manually fix a song's incorrect metadata, and I get this error. It seems I am unable to do anything in the "edit tags" mode without getting this error

[image: image] https://user-images.githubusercontent.com/108306155/178170652-d638e570-4c07-4cf7-bfca-b5f5b397bb75.png

— Reply to this email directly, view it on GitHub https://github.com/Marekkon5/onetagger/issues/121#issuecomment-1179849814, or unsubscribe https://github.com/notifications/unsubscribe-auth/AID7DUC3PW6AKPKMQWK5MRLVTNXYZANCNFSM52ABL7KQ . You are receiving this because you were mentioned.Message ID: @.***>