Marekkon5 / onetagger

Music tagger for Windows, MacOS and Linux with Beatport, Discogs, Musicbrainz, Spotify, Traxsource and many other platforms support.
https://onetagger.github.io/
GNU General Public License v3.0
618 stars 32 forks source link

Skipping Not Quite Working #196

Closed TommyMcMusic closed 1 year ago

TommyMcMusic commented 1 year ago

So i have been scanning some music today and I noticed there was tracks that were being skipped in the scanning process that didn't have a 1T, artwork or any release year, after a bit more digging it seems to happen quite alot. Any thoughts?

As this music is part of my rekordbox collection there is some meta data it does contain but non of the above, the only info i have on my tags prior to scanning is the Genre, BPM & Key, all of which come from Rekorbox itself.

The tracks that are skipped didn't seem to have a common issue, it seemed to be random becuase as I said, all my mp3s have the above info on the meta data but digging further I have found that the ones that are skipped are tags that are ID3V2.4.0 where as the tracks that are scanned as normal are ID3V2.3.0

So for whatever reason, its seeing 2.4.0 tags as already tagged even though they aren't

Marekkon5 commented 1 year ago
  1. You can check the log for the skip reason
  2. Your tracks must have title + artist tag (or Shazam or parse filename enabled)
  3. 1T checks for 1T_TAGGEDDATE tag whether to skip or no
TommyMcMusic commented 1 year ago

I already do have Shazam & parse filename enabled

Marekkon5 commented 1 year ago

Could you provide the log? (Maybe delete the old one first, run once and then send). Thank you.

TommyMcMusic commented 1 year ago

2023-03-11 13:09:12 [INFO] onetagger_autotag: [spotify] State: Skipped, Accuracy: None, Path: /Volumes/Core Drive/Music/Student/Beastie Boys - Fight for your Right (To Party).mp3

This is an example of one of the tracks that does not scan

Marekkon5 commented 1 year ago
  1. Could you send the whole log as it contains more information?
  2. You can hover with your mouse over the yellow skipped icon to see the reason it was skipped.
TommyMcMusic commented 1 year ago

Yeah sure here we go onetagger.log

Marekkon5 commented 1 year ago

It seems that the skipped tracks do not have title + artist, so they fallback to using Shazam, however Shazam fails because the file seems to be corrupt (or have some little corrupt audio frames).

You can use tools like AudioTester to check if your files are corrupt https://codecpack.co/download/audiotester.html

TommyMcMusic commented 1 year ago

Ok thats possible but why are the skipped tracks almost exclusively 2.4.0?

Marekkon5 commented 1 year ago

Most likely because of the source? 1T seems to read your ID3v2.4 tags fine, but fails to find the title + artist, and then it fails on decoding the audio data for Shazam, so the tag seems to be fine/readable, the audio not (perfectly).

TommyMcMusic commented 1 year ago

Can it be relaxed in some way so it doesn't need a perfect read, its not tagging a massive amount of music because of how seemingly perfect it needs to be, in large collections such as mine, its likely to be a problem alot of people come up against, any way to get around this?

TommyMcMusic commented 1 year ago

I also tried putting in the title and artist manually and it still skipped

TommyMcMusic commented 1 year ago

Ok so I got it to scan correctly, i reconverted the mp3's and it found everything just fine

Marekkon5 commented 1 year ago

There are also tools which can "repair" the mp3 files. Or reencoding should work too.

TommyMcMusic commented 1 year ago

I still don't know how to identify mp3's in batch that don't have artwork, how can I do that on mac, i can't seem to get a clear answer on google

Marekkon5 commented 1 year ago

Depends on what is the purpose of it:

TommyMcMusic commented 1 year ago

So here is an example of a track that I can't get any hits on, it comes up as failed not skipped

Block & Crown - Take Control

I used a mp3 repair tool only to find it doesn't need repair, i then reconverted the mp3 and scanned again and it still doens't find anything

I double checked on google to amke sure its still available for sale on all the stores and streaming platofrms and it is

Marekkon5 commented 1 year ago

I've copy pasted the title and artist to a dummy mp3 file and started 1T with Deezer enabled. It detected the track.

Are your title & artist tags correct?

image

TommyMcMusic commented 1 year ago

It seems that MusicBrainz was the issue, it has now found it, and on another 2 tracks i had disable shazam for them to be found

Marekkon5 commented 1 year ago

You might want to keep Shazam on, but disable the "Force Shazam" to make it not always Shazam if tags are available.