Marekkon5 / onetagger

Music tagger for Windows, MacOS and Linux with Beatport, Discogs, Musicbrainz, Spotify, Traxsource and many other platforms support.
https://onetagger.github.io/
GNU General Public License v3.0
623 stars 33 forks source link

Audio Features tagging should escape "(Origina Mix)" #3

Closed rosgr100 closed 3 years ago

rosgr100 commented 3 years ago

Hi, when the title of a track contains (Original Mix) onettager is not able to find it in Spotify. This is probably happening because Spotify does not use the (Original Mix) as a description in the titles.

Screenshot 2021-05-20 164229

bascurtiz commented 3 years ago

Thanks for letting us know @rosgr100 .

  1. We've tried to mimick it by finding the track thru the webplayer of Spotify.
  2. We've tried to mimick it by finding the track thu the API of Spotify.

Both are unlucky. See if you can replicate. For API usage go to: https://developer.spotify.com/console/get-search-item/ Fill in Q with Artist - Title , Fill in Type with track, Click Get Token and select some option (doesn't matter which one) & click Try it. It will spam the results at bottom-right of the page.

Webplayer: A. https://open.spotify.com/search/3than%20-%20dont%20you%20know ends up in: image

B. https://open.spotify.com/search/3than%20-%20don't%20you%20know ends up in the same results.

C. https://open.spotify.com/search/3than%20-%20don%60t%20you%20know ends up in: image But as you can see, only the remixes.

API: A. https://developer.spotify.com/console/get-search-item/?q=3than%20dont%20you%20know&type=track&market=&limit=&offset=&include_external= ends up in: image

B. https://developer.spotify.com/console/get-search-item/?q=3than%20don%27t%20you%20know&type=track&market=&limit=&offset=&include_external= ends up in no result.

C. https://developer.spotify.com/console/get-search-item/?q=3than%20don%27t%20you%20know&type=track&market=&limit=&offset=&include_external= ends up in: image Incl. all remixes, and album, but not the track 3than - Don't You Know itself.

Can you provide more examples? Because this track in particular looks like trouble on the API side of Spotify.

rosgr100 commented 3 years ago

I was able to find the track through the desktop app but only as a part of an "album".

Screenshot 2021-05-21 004725

You will find enough examples in the list bellow.

ONETAGGER.txt

One more example, although Beatport is using the "Original Mix" in the title.

Screenshot 2021-05-21 005500

This is from the webplayer Screenshot 2021-05-21 005517

By the way, there are tracks which are let's say "exclusive" to stores like Beatport or Traxsource as a full track. Spotify usually offers a shorter, "EDIT" version of the original mix, probably this will also be a problem.

Marekkon5 commented 3 years ago

Hello, in the latest commit, I've fixed the searching in Spotify, I was able to find the Pressure - Original Mix song correctly now.

rosgr100 commented 3 years ago

Hi , thank you for all the efforts you put in to solving the issues.

So, the issue is solved for tracks with "- original mix" in the title. But the problem still exist when Spotify, for some reason, doesn't include "original mix" in the title.

Screenshot 2021-05-24 004748

Screenshot 2021-05-24 005345

Screenshot 2021-05-24 005853

Screenshot 2021-05-24 005910

Maybe a solution would be an IF parameter, something like IF Artist - Track (Original Mix) fails THEN check for Artist - Track

Marekkon5 commented 3 years ago

Added a patch on master, which cleans up the search query same way as for other platforms. I got match on the tracks you sent. Let me know if it works. Thank you.

rosgr100 commented 3 years ago

Mostly, it seems to be working now but... I found another weird behavior by Spotify. There are tracks, which although they are available in Spotify, One Tagger is not able to find them, this is happening because of the dash between artist and the title.

Screenshot 2021-05-24 220537

Artist - Title = No match

Screenshot 2021-05-24 220645

Artist Title = Voila

Screenshot 2021-05-24 220559

Marekkon5 commented 3 years ago

I've implemented a fix, because it is common with search engines, you can try on master.

However I don't think problem in this song is the -. 1T uses your first artist in metadata + track title joined with space as query - doesn't add - itself, so in this case it doesn't change anything. It's I think the (Extended Mix) that's causing the problem.

rosgr100 commented 3 years ago

Removing the dash didn't do the trick, so you are right, (Extended Mix) is the one to blame.

Marekkon5 commented 3 years ago

Since extended mixes are slightly different from normal releases I'd consider this more like Spotify doesn't have this track in library rather than 1T problem. Is there any more problems related to this or can this issue be closed?

rosgr100 commented 3 years ago

I see. Yes, you can close it, till now i didn't find any other problem regarding this issue.

Once again, thank you for your time! 😉👏