Marekkon5 / onetagger

Music tagger for Windows, MacOS and Linux with Beatport, Discogs, Musicbrainz, Spotify, Traxsource and many other platforms support.
https://onetagger.github.io/
GNU General Public License v3.0
611 stars 32 forks source link

Seek not working >Actions Build #407

Open Nickyg001 opened 2 months ago

Nickyg001 commented 2 months ago

Using the latest build found in >Actions I realized that there is a problem with scrolling forward and backward through the audio track, so the song always starts from the beginning.

Marekkon5 commented 2 months ago

Which format?

Nickyg001 commented 2 months ago

Quale formato? what do you mean by format? I downloaded this build for windows [Traxsource limit]

Marekkon5 commented 2 months ago

I meant what format of audio files do you use and had this issue? MP3, FLAC, AIFF, ALAC, AAC?

Nickyg001 commented 2 months ago

MP3

bascurtiz commented 2 months ago

https://github.com/user-attachments/assets/8a04f30e-46d1-4405-9f97-c769695e3142

Works fine on my mp3's as u can see.

Can you sent a few mp3's so we can check if it's related to your mp3's somehow? Upload them to mega.io, google drive or onedrive or so and share.

Nickyg001 commented 2 months ago

OneTagger 1.7 download from website link: https://github.com/Marekkon5/onetagger/releases/download/1.7.0/OneTagger-windows-setup.exe This version works the seek of the track forward and backward (tested with mp3 files)

This is the latest available version updated in Actions: https://github.com/Marekkon5/onetagger/actions/runs/9587384200/artifacts/1618361591

This updated version DOES NOT work the seek (same mp3 files as before). So the problem IS NOT the mp3 files but the software.

Es. v1.7.0_b1 / b2 / b3 ....

PS: how can you detect which build is installed on the computer? I always see 1.7 but I could not understand if it is the one of the site or of the actions (obviously apart from the new functions). Would this addition to the software be possible?

bascurtiz commented 2 months ago
  1. I tested the version you linked to, but it works fine, see video.
  2. To show which commit build you are using, hit F3 in One Tagger, see video.

https://github.com/user-attachments/assets/d1bfeb2e-afb3-4c46-a5bc-93917175f0ee

Nickyg001 commented 2 months ago

I saw your video and it works.

I installed the same build as yours (identical). Only that when I go forward and backward on the track the song always starts from the first beat at 00:00 ... With the other software 1.7 (the other link works well for me).

I can't make a video of the screenshot but it happens exactly as I described and I don't understand why since it works well for you.

PS: With the MP3 file I have this problem, converting the same files to WAV, it doesn't even find the meta tags from the online platforms (various). With the other version 1.7 of the site instead: WAV doesn't find the tags, seek works... but F3 doesn't work with this version to see the build?

PS2: Sorry if I highlight these problems, but in all versions I find the management of the path selection of the folders' path not intuitive. Can't you select the path by browsing the folder paths like in all software? Do I have to paste the source path manually?

Marekkon5 commented 2 months ago

Can you try the latest action build? It has fixes related to this.

Re. PS1: WAV has a very unstandardised tag system, onetagger supports only wav + id3. Maybe your conversion software did use different format. Either way we strongly advise NOT to use WAV files due to this, and also because FLAC files in general offer better metadata support and lossless compression.

Re. PS2: You can click the text (not pencil) to open the system browse dialog.

Nickyg001 commented 2 months ago

Can you try the latest action build? It has fixes related to this.

Re. PS1: WAV has a very unstandardised tag system, onetagger supports only wav + id3. Maybe your conversion software did use different format. Either way we strongly advise NOT to use WAV files due to this, and also because FLAC files in general offer better metadata support and lossless compression.

Re. PS2: You can click the text (not pencil) to open the system browse dialog.

I solved the Seek problem by unchecking client side player (for server mode) image

The Browser Problem: When I selected a path inside USER/username I don't see the option to select the disk drives (C:/ D:/ E:/ etc..) this was my problem (and the problem still exists). image

If instead I am in a folder e.g. C:/myfolder I can access the drives image

Marekkon5 commented 2 months ago

You can try checking the Client side folder browser option in advanced settings, it might solve this issue.

Nickyg001 commented 2 months ago

You can try checking the Client side folder browser option in advanced settings, it might solve this issue.

No it doesn't solve it, it even makes it worse. Not only do I not fit the Disk Drives, but I can't even resize, stretch the window for a more efficient browsing of the folders

image

Marekkon5 commented 2 months ago

Sadly this is the behavior of the native folder picker. I can remove the path context, but then it would always open in the disk selection format, and if you want to use the dialog to just go to simillar path it would be very uncomfortable. Sorry, but I don't know of a solution at the moment.

bascurtiz commented 2 months ago

The Browser Problem: When I selected a path inside USER/username I don't see the option to select the disk drives (C:/ D:/ E:/ etc..) this was my problem (and the problem still exists).

Works fine though? See video:

https://github.com/user-attachments/assets/a347b5a9-8b83-4e2e-9566-00f77f0e29b7

Nickyg001 commented 2 months ago

build: 852512db

https://github.com/user-attachments/assets/7975c00b-00eb-4c60-9656-920d43dbab66

bascurtiz commented 2 months ago

Tried it on a Windows 11 fresh install too, but it should show 'This PC' by default. It does for me on both Win10 and 11, while it doesn't seem to show for you initially.

Can you hit F3 and make a screenshot and post like I did here?

1t-browser-win11

1t-browser-win11_F3

Nickyg001 commented 2 months ago

image image

bascurtiz commented 2 months ago

Is it a local account? Or a Microsoft account? You can check using one of the options mentioned here: https://www.tenforums.com/tutorials/5387-how-tell-if-local-account-microsoft-account-windows-10-a.html

Nickyg001 commented 2 months ago

account Microsoft