search

Marekkon5 / onetagger

Music tagger for Windows, MacOS and Linux with Beatport, Discogs, Musicbrainz, Spotify, Traxsource and many other platforms support.
https://onetagger.github.io/
GNU General Public License v3.0
623 stars 33 forks source link

Custom tag separator doesn't work #71

Closed shayded-exe closed 2 years ago

shayded-exe commented 2 years ago

I'm using / as a custom separator. My songs show all my custom tags as a single tag.

image

onetagger commented 2 years ago

Did you set the separator to / in Settings?

image

shayded-exe commented 2 years ago

Yes. It's really weird because once I edit and save the tag, the vibes are split out into multiple chips like they should be, but once I reload the page, they're back to being a single chip.

I'll record a video of what's happening later today.

shayded-exe commented 2 years ago

Ok here's a video of the issue. Very strange. I looked through the related code myself but couldn't figure out why this might be happening.

Thanks!

https://user-images.githubusercontent.com/1417838/148474337-f58028c8-a1b0-4689-8318-7bff2e02f01d.mp4

bascurtiz commented 2 years ago

Thanks for the video! Strange indeed... I've tried to replicate, but I can't. Even after switching to Audio Features, or adding tags from the right panel. Maybe related to file format? I've used mp3.

Could you upload 2-3 tracks in a zip, so I can inspect further?

shayded-exe commented 2 years ago

Strange, I'm using mp3 as well.

Here's the first 2 tracks and my settings.json file.

One Tagger Bug.zip

Marekkon5 commented 2 years ago

I copied your separator settings and couldn't reproduce it. What version are you using? 1.3.0 from website or the latest Github Actions build? If the first one, try downloading the latest Github Acitons build. Thanks

shayded-exe commented 2 years ago

I was using 1.3.0 from the latest GitHub release. I just installed the latest build and it's working now! It's also now showing the rating year and key as well.

One issue I have now is that it's only showing the first genre. Will there be support for multiple genres or subgenres in the future?

SunwalkerDJ commented 2 years ago

I was using 1.3.0 from the latest GitHub release. I just installed the latest build and it's working now! It's also now showing the rating year and key as well.

One issue I have now is that it's only showing the first genre. Will there be support for multiple genres or subgenres in the future?

A little offtop:

I don't understand anything about programming and backend Could you send me a compiled file of the latest build, if you have one?

Thx! My email: mail@sunwalker.dj

Marekkon5 commented 2 years ago

I was using 1.3.0 from the latest GitHub release. I just installed the latest build and it's working now! It's also now showing the rating year and key as well. One issue I have now is that it's only showing the first genre. Will there be support for multiple genres or subgenres in the future?

A little offtop:

I don't understand anything about programming and backend Could you send me a compiled file of the latest build, if you have one?

Thx! My email: mail@sunwalker.dj

You can just click the Actions tab on top in Github to get the latest precompiled builds.

Marekkon5 commented 2 years ago

I was using 1.3.0 from the latest GitHub release. I just installed the latest build and it's working now! It's also now showing the rating year and key as well.

One issue I have now is that it's only showing the first genre. Will there be support for multiple genres or subgenres in the future?

For long time we said, that we decided that genres should be a single-value and that you can use custom tag for it, however a bunch of people requested this so, I've changed it. You can now have multiple genres in the latest commit. You can get the binary in actions.

shayded-exe commented 2 years ago

Awesome! Thank you so much for looking into this so quickly

SunwalkerDJ commented 2 years ago

I was using 1.3.0 from the latest GitHub release. I just installed the latest build and it's working now! It's also now showing the rating year and key as well. One issue I have now is that it's only showing the first genre. Will there be support for multiple genres or subgenres in the future?

For long time we said, that we decided that genres should be a single-value and that you can use custom tag for it, however a bunch of people requested this so, I've changed it. You can now have multiple genres in the latest commit. You can get the binary in actions.

Thanks! This is a very useful innovation

But it would be cool to add the possibility of choosing a custom separator for genres I think it would be useful for many people:

For example, my genres are always in this format: Disco / Funk / Latin

Marekkon5 commented 2 years ago

The custom separator in QuickTag should work with genre too.