search

Marfjeh / coinhive-block

To block the malware domains of coin-hive systemwide.
MIT License
89 stars 20 forks source link

Fix make.js #17

Closed ghost closed 6 years ago

ghost commented 6 years ago

@megaxlr I changed it all. Works on MacOS and Windows now. The semicolon is not needed, and by standardJS standards it should not be included.

ghost commented 6 years ago

Ill pull and test your branch in a moment. But from what I can see, I don't think the inconsistencies considering the header and footer have been fixed which is a major flaw.

EDIT: The inconsistencies are not fixed. Domains are still appended in front of the header and domains are appended after the footer.

The filestream also is not gracefully closed.

ghost commented 6 years ago

Closing this as of GH-0018