Marfusios / bitfinex-client-websocket

🛠️ C# client for Bitfinex & Ethfinex websocket API version 2.0
Apache License 2.0
55 stars 38 forks source link

Update streams objects to publicly expose underlying Subjects #44

Open shaynevanasperen opened 2 years ago

shaynevanasperen commented 2 years ago

I've exposed the underlying Subject<T> members in both xxStreams classes. This is because I want to be able to stream fake messages for testing my program which uses this library. Although that was already possible by using fake IWebsocketClient objects, that method is very clunky and requires that I send raw text instead of just POCO objects. There is no good reason for hiding the Subject<T> members behind IObservable<T>, so the most straight-forward way to enable easy testing is to just expose the Subject<T> members directly.

Summary of changes:

Marfusios commented 2 years ago

Hey @shaynevanasperen ,

thanks for the PR. Could you please split it into multiple separate PRs?

5000+ lines are definitely too much for a proper review.

A few high-level points: