Fixed the issue in #114: Disposing an inactive WebsocketClient no longer triggers DisconnectionHappened

Marfusios / websocket-client

🔧 .NET/C# websocket client library

MIT License

692 stars 127 forks source link

Fixed the issue in #114: Disposing an inactive WebsocketClient no longer triggers DisconnectionHappened #116

Closed JacquelineCasey closed 2 years ago

JacquelineCasey commented 2 years ago

See #114.

I updated a test to catch this new behavior, and then I updated the code accordingly (this only required a tiny change).

Marfusios commented 2 years ago

Hey @jackcasey067 , sorry for the late response. Thanks for the PR.

Theoretically, it is a breaking change, because someone can expect IsRunning=false inside DisconnectionHappened stream. But I believe it is minor. Merging.