Marginal / QLVideo

This package allows macOS Finder to display thumbnails, static QuickLook previews, cover art and metadata for most types of video files.
GNU General Public License v2.0
2.51k stars 87 forks source link

Blurry & slow thumbnail image after upgrading to 2.0 #109

Open goodman-capu opened 1 year ago

goodman-capu commented 1 year ago

Example of a blurry thumbnail image. This happens to 100% of my video files.

2.0 is noticeably slower than previous versions. For example I have a folder on an external HDD which contains ~50 video files, each file is around 10GB. Previously, QLVideo will generate all the thumbnails in less than 10 seconds. Now each file takes around 2-3 seconds.

https://github.com/Marginal/QLVideo/issues/108

Screenshot 2023-01-24 at 11 19 17 AM

QLVideo: 2.00 macOS: Version 13.2 (Build 22D49) Hardware: MacBookPro15,1 x86_64 avx2=yes avx512f=no mdimport: Imported 'file.mov' of type 'com.apple.quicktime-movie' with plugIn /System/Library/Spotlight/CoreMedia.mdimporter. 42 attributes returned .

{
  "programs": [
  ],
  "streams": [
    {
      "codec_name": "h264",
      "profile": "Main",
      "codec_type": "video",
      "codec_tag_string": "avc1",
      "width": 1704,
      "height": 824,
      "display_aspect_ratio": "213:103",
      "pix_fmt": "yuv420p",
      "disposition": {
        "default": 1,
        "attached_pic": 0,
        "timed_thumbnails": 0
      }
    }
  ],
  "format": {
    "format_name": "mov,mp4,m4a,3gp,3g2,mj2",
    "duration": "10.233333",
    "size": "635623",
    "bit_rate": "496903",
    "probe_score": 100
  }
}
goodman-capu commented 1 year ago

I can confirm this issue also exists on another M1 Pro MacBook Pro (macOS 13.2).

goodman-capu commented 1 year ago

I can confirm this issue also exists on another Intel i5 MacBook Pro (macOS Big Sur 11.1).

xxmmllqqqqccqq commented 1 year ago

Same here on intel i5 MacBook Pro with macOS Big Sur 11.7.2

vbwx commented 1 year ago

I can confirm that it's taking QLVideo multiple seconds to generate thumbnails for MP4 files in particular (per file), and if there are many files in a folder that QLVideo has to create thumbnails for, the thumbnailer process sometimes gets stuck and is using up 300% of the CPU.

Running macOS 12.6.3 on an Intel Core i7 MacBook Pro.

Kagami commented 10 months ago

if there are many files in a folder that QLVideo has to create thumbnails for, the thumbnailer process sometimes gets stuck and is using up 300% of the CPU

Yeah, it's not clear what is Finder doing under its hood. I even don't have some thumbnails for mp4 files which should be generated natively... Maybe it goes crazy and iterates over all videos files in Spotlight index, maybe gets some errors during it and just stops. Then maybe it will continue again but not clear when and why some valid files are still missing thumbnail. Very opaque kind of process.

Also from another issue https://github.com/Marginal/QLVideo/issues/49#issuecomment-377776934

Looks like a Finder issue since this plugin isn't called to render the missing icon.

Seems to be some strange internal Finder's way of working with caches/index/thumbnails...