search

Marginal / QLVideo

This package allows macOS Finder to display thumbnails, static QuickLook previews, cover art and metadata for most types of video files.
GNU General Public License v2.0
2.59k stars 88 forks source link

Black borders in thumbnails #118

Closed Kagami closed 1 year ago

Kagami commented 1 year ago

Hi,

Thanks for great plugin, I like it a lot. Mostly works without issues. But one visual unfortunate glitch is that it generates black borders for small video thumbnails in icon view in Finder. This doesn't happen with photo thumbnails. See attached screenshots.

I found this issue https://github.com/Marginal/QLVideo/issues/19 which was resolved. But then it was discussed again here https://github.com/Marginal/QLVideo/issues/63#issuecomment-569933112 and it seems to be a flaw of Quick Look Plugin API? So no workaround possible? Please confirm if so.

Although cover thumbnails for mkv look fine. See last screenshot. Is it possible to generate thumbnails from video frames in the same way?

Thanks.


Marginal commented 1 year ago

Finder decorates thumbnails according to file type - thin white borders for pictures (like a printed photo), black borders for movies (like letterbox mattes), no borders for movie cover art (like a physical film poster?). There are also some other obscure/historical decorations.

I could suppress the black borders or replace them with something else, but I wanted to stay consistent with macOS behaviour.