Marginal / QLVideo

This package allows macOS Finder to display thumbnails, static QuickLook previews, cover art and metadata for most types of video files.
GNU General Public License v2.0
2.51k stars 87 forks source link

Anyone got it working on Sonoma? #121

Open anoniniarz opened 5 months ago

anoniniarz commented 5 months ago

For me on 14.4 and QLVideo version 2.00 does not seem to work at all. Sometimes it generates few thumbnails and then stops and does nothing, and now there is nothing, not a single thumbnail neither for any mkv or webm file. I tried reinstalling multiple times, rebooting, re-indexing whole drive, refreshing cache, changing default app for webm files between IINA and mpv and nothing seems to be working.

Kagami commented 5 months ago

It works for me on latest Sonoma, although sometimes thumbnails are missing, but eventually they re-appear. You may try https://github.com/Marginal/QLVideo/issues/112#issuecomment-1742207395

low-batt commented 5 months ago

Have you followed the instructions in Getting Started and Troubleshooting?

Especially the instruction to press the Refresh button: issue-121

I just installed QuickLook Video on my MacBookPro16,1 running macOS Sonoma 14.4 and it is working. I did have to press the Refresh button before Finder started showing thumbnails for video files using codecs not natively supported by macOS.

Issue #119 reports trouble with .mid and .sf2 SoundFont files. Do you have any of those files on your Mac?

In Finder right click on a file without a thumbnail and select Get Info. In the window that appears expand the disclosure triangle labeled More Info Look for Codecs. Which codecs are being used by the file without a thumbnail? issue-121-get-info

anoniniarz commented 5 months ago

First of all, thanks for very detailed reply. Yes, I did press refresh button multiple times, I meant that by „refreshing cache” although I used qlmanage -r cache too. I do not have any .mid and .sf2 files on my Mac. As for codecs, it doesn’t work neither for VP9, VP8 or H264

I tried that killall -9 com.apple.quicklook.ThumbnailsAgent but it generates thumbnails for like 20 webm files out of 140 in that folder and then stops and does nothing.

low-batt commented 5 months ago

Bummer. Maybe it is having trouble with one of the files in that directory.

In Building in the Debugging section indicates:

All plugins produce output in the system log. Use the filter subsystem:uk.org.marginal.qlvideo in the Console app.

  • mdimporter - Invoke for debugging with mdimport -n -d3 <testfile>
  • glgenerator - Invoke for debugging with qlmanage -p <testfile>
  • thumbnailer - Invoke for debugging with qlmanage -t -f2 <testfile>

If you can see a pattern of the order in which it was generating thumbnails and can tell which file it stopped at, try running qlmanage -t -f2 on that file.

Also try bringing up Console and searching for QLVideo to see if there are any error messages that provide a clue to the problem. issue-121-console

Kagami commented 5 months ago

Maybe it is having trouble with one of the files in that directory.

That was my experience too. As far as I can understand QLVideo have issues with some of my webms like with alpha channel or non 4:2:0 subsampling and got stuck on them. So I just moved those problematic videos to another folder and it kinda fixed the issue. Although I'm not completely sure because it's hard to understand what's going on in the background.

low-batt commented 5 months ago

Try using qlmanage -t -f2 <testfile> on one of those files and see if that command hangs.

If you have a problematic video file that you are able to share publicly, post it here and I will try and proproduce the problem on my Mac.

Kagami commented 5 months ago

Try using qlmanage -t -f2 on one of those files and see if that command hangs.

sample.webm Try this one. It's broken (ffmpeg prints File ended prematurely) but it unfortunately makes QLVideo stuck.

I guess I have few files like that in my folders which QLVideo doesn't like :)

low-batt commented 5 months ago

I downloaded the video and confirmed QuickLook Video is having trouble with that file.

I'm trying to build a debug version of QuickLook Video. Currently struggling with build errors.

anoniniarz commented 5 months ago

Okay so I've waited for a while to let it do it's thing, and few things happened. First, it generated thumbnails for every webm/mkv file on my mac, even on external drive, I thought that it is working fine then. But now I came back to my webm folder and ALL thumbnails are gone again. Is this expected behavior or spotlight "feature"? To be clear, I did not unplud external ssd and it is formatted in APFS. I am losing my mind right now, it's so annoying.

Kagami commented 5 months ago

ALL thumbnails are gone again

On external drive? I mount folders with videos from my NAS via SMB and yeah, it seems like Finder regenerates thumbnails every time when I browse mounted folder. It's a bit annoying but I didn't try to dig deeper.

low-batt commented 5 months ago

Try this. Start the QuickLook Video application. Note the position of the slider and the 1m. This controls the position at which QuickLook Video will capture a thumbnail. Slider the slider's knob to the left until 5s is shown:

issue-121-position

When I did that testing thumbnail generation by running this common on the file posted above:

qlmanage -t -f2 312632441-47f7822b-e4ae-4df2-becb-4fc46aab9711.webm 

Generated a thumbnail:

low-batt@urp 121$ qlmanage -t -f2 312632441-47f7822b-e4ae-4df2-becb-4fc46aab9711.webm 
Testing Quick Look thumbnails with files:
    312632441-47f7822b-e4ae-4df2-becb-4fc46aab9711.webm
* /Users/low-batt/Documents/builds/qlvideo/issues/121/312632441-47f7822b-e4ae-4df2-becb-4fc46aab9711.webm produced one thumbnail
Done producing thumbnails
low-batt@urp 121$ 

Whereas before it failed to generate the thumbnail:

low-batt@urp 121$ qlmanage -t -f2 312632441-47f7822b-e4ae-4df2-becb-4fc46aab9711.webm 
Testing Quick Look thumbnails with files:
    312632441-47f7822b-e4ae-4df2-becb-4fc46aab9711.webm
* No thumbnail created for /Users/low-batt/Documents/builds/qlvideo/issues/121/312632441-47f7822b-e4ae-4df2-becb-4fc46aab9711.webm
Done producing thumbnails
low-batt@urp 121$ 

When it fails to generate a thumbnail it takes about a minute for qlmanage to timeout.

As that file prematurelly ends I can see how QuickLook Video would run into trouble trying to capture a thumbnail 60 seconds into the video. Trouble is if I set it to 4s instead of 5s it also fails to generate a thumbnail.

It seems like there is more than one problem. I will continue to investigate.

anoniniarz commented 5 months ago

ALL thumbnails are gone again

On external drive? I mount folders with videos from my NAS via SMB and yeah, it seems like Finder regenerates thumbnails every time when I browse mounted folder. It's a bit annoying but I didn't try to dig deeper.

It was for both external and internal drive

Try this. Start the QuickLook Video application. Note the position of the slider and the 1m. This controls the position at which QuickLook Video will capture a thumbnail. Slider the slider's knob to the left until 5s is shown:

i have mine set to 1s

low-batt commented 5 months ago

I'm still looking into this. Taking a while since I've never looked into the QLVideo code before.