Marginal / QLVideo

This package allows macOS Finder to display thumbnails, static QuickLook previews, cover art and metadata for most types of video files.
GNU General Public License v2.0
2.56k stars 88 forks source link

Option to enable "Matroska Cover Art" as thumbnail #18

Closed enjikaka closed 9 years ago

enjikaka commented 9 years ago

Here's some info about Matroska Cover Art: http://matroska.org/technical/cover_art/index.html

Would be nice if, instead of a frame from the movie as a thumbnail, you could choose to enable having the cover art provided in the matroska file (and of course fallback to frame if non exists).

Marginal commented 9 years ago

Haven't come across an mkv with cover art in the wild, but thanks for the link.

enjikaka commented 9 years ago

It's not very common. But a really nice feature. It's mainly used by media-centers. I've added covers to alot of my local MKV files.

The Windows program Icaros from Shark007 has this feature.

enjikaka commented 9 years ago

A nice, you integrated it!? :dancer:

I forgot to mention there can be two types of cover art attached, portrait and landscape. Would be nice if both were supported and if you could choose to use landscape instead of portrait!

In "Icaros" you have these options; would be nice if QLVideo worked the same! Image

Marginal commented 9 years ago

On OSX the thumbnailer runs as a sandboxed system process for security, so it can't see the current user's preferences. My implementation prefers the square/portrait version over the landscape version if both are present because Finder always asks for square thumbnails.

Marginal commented 9 years ago

Release 1.81 uses embedded cover art (the square/portrait version in the case of mkv files with multiple cover art) to generate video thumbnails.

enjikaka commented 9 years ago

Awesome. My hat's off to you!

enjikaka commented 9 years ago

In the "Cover Flow"-view the cover art displays as expected:

But in the "Icon"-view the cover art gets a letterbox around it;

The "Column"-view does not display the cover art at all.

Is there a way to fix that?

Marginal commented 9 years ago

But in the "Icon"-view the cover art gets a letterbox around it;

Unfortunately I don't know of any way of suppressing the letterbox that gets added in Icon and List views.

The "Column"-view does not display the cover art at all.

QuickLook supplies content in three situations:

As of version 1.81 QLVideo does this when asked by QuickLook for content:

I'm open to the idea of supplying cover art (if present) in some more of these cases. But:

enjikaka commented 9 years ago

Unfortunately I don't know of any way of suppressing the letterbox that gets added in Icon and List views.

Ah okey!

In which of these cases should the landscape version of the cover art be displayed

I think that's more of a user preference. I'd rather have the portrait version everywhere...

Does it make a difference if the alternative to supplying cover art is a playable preview or a static snapshot?

I'd prefer if the portrait cover art is shown, if that does not exists, a static screenshot. I don't really care about playable previews.

Is it possible to add radio-boxes to the "Show View Options" panel? Would be nice if you could right click the MKV file and have something like this (bottom compartment):

Marginal commented 9 years ago

Is it possible to add radio-boxes to the "Show View Options" panel?

No. The thumbnailer runs as a sandboxed system process for security, so it can't see the current user's preferences (other than desired thumbnail size - and the thumbnail size is always square).

Please try this version:

enjikaka commented 9 years ago

Will try it out tomorrow and give feedback!

Marginal commented 9 years ago

Fixed in release 1.82.

Marginal commented 9 years ago

But in the "Icon"-view the cover art gets a letterbox around it;

This is fixed in release 1.83.