Marginal / QLVideo

This package allows macOS Finder to display thumbnails, static QuickLook previews, cover art and metadata for most types of video files.
GNU General Public License v2.0
2.54k stars 88 forks source link

Show Error Preview If Generation Failed #42

Closed acuntex closed 1 year ago

acuntex commented 7 years ago

Hi,

is there any way QLVideo could show some Placeholder Image as Preview if it wasn't able to create a preview instead of the default Finder image?

I'm always wondering if it failed or if I still have to wait for some preview image.

Thanks!

Marginal commented 7 years ago

Could do, but I'm not sure why a placeholder image would be better than your media player app's icon.

The polite thing for a plugin to do is the current behaviour - say that it can't generate a preview/thumbnail so that QuickLook can hand off to another plugin if there is one.

acuntex commented 7 years ago

Unfortunately Quicklook does not handle it by another plugin.. e.g. the default one which in some cases would generate thumbs but QLVideos doesn't. Sometimes it takes time to generate the thumb and when you browse through folders you are not sure: Is he not able to do it or does it hang?

qlmanage -r helps the plugin to continue and then some videos get a thumb, some don't.

I miss the old time when Perian worked :(

acuntex commented 7 years ago

One more thing: I saw that in Snapshotter.m e.g. are a lot of "return nil".

Would it be possible to log on a certain loglevel like -d2 why the plugin wasn't able to generate a thumbnail?

Marginal commented 1 year ago

Closing as won't (actually can't) fix. Unfortunately this app can't know whether another plugin might be able to produce a thumbnail or preview. It would be rude to return a placeholder image when another plugin (perhaps one of Apple's builtin plugins) might be able to.