search

Marginal / QLVideo

This package allows macOS Finder to display thumbnails, static QuickLook previews, cover art and metadata for most types of video files.
GNU General Public License v2.0
2.51k stars 87 forks source link

Update to ffmpeg 5.1; aom 3.4; gas to 9309c67 #97

Closed exgphe closed 1 year ago

exgphe commented 2 years ago

Update all the dependencies to latest release version

eirnym commented 1 year ago

Nice work

eirnym commented 1 year ago

This fixes a lot of build problems with QLVideo on M2

exgphe commented 1 year ago

It requires some modifications to the building scripts to make it build on Apple Silicon Macs. But my version is too hacky and complex for a pull request.

Le 10 sept. 2022 à 18:36, Eir Nym @.***> a écrit :

 This fixes a lot of build problems with QLVideo on M2

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

eirnym commented 1 year ago

Could you share modifications you've used?

I added a few minor modifications:

  1. search for headers in $(BUILT_PRODUCTS_DIR)/ffmpeg/arm64 (or copy them back to ffmpeg)
  2. exclude arch x86_64 (I haven't installed Rosetta yet and I don't plan to)
  3. replace dylib external libraries with static ones (search and replace in project.pbxproj file). All dylibs are used from Homebrew
  4. I use MacPorts, so paths to these libraries are also going to change a little
  5. Write an installer script to put results from build folder to proper places

As result QLVideo works well for me.

I had no luck to build from Xcode GUI

eirnym commented 1 year ago

Without your patch it was impossible for me to build a proper binary.

Marginal commented 1 year ago

Thanks for the PR. Closing in favour of d6fc176dc9a200aba5ef3987bc6a3542f1affc38