Marginal / docker-get_iplayer

A smallish (100MB) Docker image that hosts the get_iplayer PVR and automatically keeps itself up-to-date with the latest version of get_iplayer
27 stars 13 forks source link

Latest version behind #1

Closed robflate closed 5 years ago

robflate commented 5 years ago

Hi,

Thanks for the docker image. The latest version of get_iplayer is 3.22 released 10 days ago but this image contains 3.21. The dockerfile pulls https://api.github.com/repos/get-iplayer/get_iplayer/releases/latest which says it's 3.22 but the webgui shows 3.21.

The readme.md says it auto updates. Is there anything I need to do to force it to update?

Thanks again, Rob.

asjmcguire commented 5 years ago

Mine was at v3.17. I tried executing the update commands in /etc/periodic/daily/ manually and it did nothing, so I removed the quiet flags from the wget command and ran them individually to see what was going on - and wget is saying 400 bad request.

I manually used wget to download wget -O 'get_iplayer-322' https://api.github.com/repos/get-iplayer/get_iplayer/tarball/v3.22; tar -zxf ./get_iplayer-322; cd get-iplayer-get_iplayer-50a6051/; install -m 755 -t /usr/local/bin ./get_iplayer ./get_iplayer.cgi and then deleted the downloaded file and restarted the docker container, it was then running v3.22 - it's probably worth double checking that the update commands are piping the right things to each other.

For me the command wget -qO - "wget -qO - 'https://api.github.com/repos/get-iplayer/get_iplayer /releases/latest' | jq -r .tarball_url" does not work, but wget -qO - 'https://api.github.com/repos/get-iplayer/get_iplayer/releases/latest' | jq -r .tarball_url | wget -i - does successfully download v3.22

Marginal commented 5 years ago

The get_iplayer version does update (unless you see any errors in /var/log/get_iplayer_update.log), but the web frontend doesn't use the new version until you stop and restart the container.

This isn't usually a problem since the web frontend rarely changes (the last material change was over a year ago), but it is confusing and could be a problem in future.

asjmcguire commented 5 years ago

EDIT: Nevermind the original command chain in the docker file works now, but it didn't last night.

v3.22 (~20 days ago) is required to refresh the feeds since changes happened at the BBC site. and I can absolutely confirm that until I manually updated the get_iplayer binary - it was unusable, no matter how many times I restarted the container.

To be clear removing the first "q" flag an running just this part of the command: wget -O - "wget -qO - 'https://api.github.com/repos/get-iplayer/get_iplayer/releases/latest' | jq -r .tarball_url" (yes the backticks are still there, I just had to remove them from this post to get it to display properly) produces: http://: Invalid host name. thus the tar is not being downloaded and piped in to the next part of the command chain.

However running wget -qO - 'https://api.github.com/repos/get-iplayer/get_iplayer/releases/latest' | jq -r .tarball_url | wget -i - -O - | tar zxf - does download and unpack the file.